Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plotHeatmap issues #606

Closed
1 of 3 tasks
vivekbhr opened this issue Sep 26, 2017 · 3 comments
Closed
1 of 3 tasks

plotHeatmap issues #606

vivekbhr opened this issue Sep 26, 2017 · 3 comments
Assignees

Comments

@vivekbhr
Copy link
Member

vivekbhr commented Sep 26, 2017

I am editing this to include multiple issues with plotHeatmap (instead of opening a series of issues).

  • heatmap center label should reflect the --reference-point argument (I think this needs changes in computeMatrix code, rather than heatmapper.

  • colorbar center should be centered at zero in case of divergent panel (I am not sure if it's because of tick labels misplacement, or the scale is actually wrong, but this stays wrong even after using a fixed zmin and zMax).

  • options to scale the signal by sample or group before running the kmeans/hclust should be provided.

@vivekbhr vivekbhr self-assigned this Sep 26, 2017
@vivekbhr vivekbhr changed the title plotHeatmap heatmap center always says "TSS" plotHeatmap issues Sep 29, 2017
@dpryan79
Copy link
Collaborator

dpryan79 commented Oct 6, 2017

Regarding the 3rd option, I would generally prefer that people handle that themselves. I'm very much against adding more options to plotHeatmap/plotProfile/computeMatrix since they're already unwieldy.

Can you give an example of the colorbar centering issue?

@dpryan79
Copy link
Collaborator

dpryan79 commented Mar 8, 2018

I've split the first point into its own issue (#683). It's starting to annoy me now, so I'll fix it.

@dpryan79
Copy link
Collaborator

dpryan79 commented Mar 9, 2018

The first issue you mentioned is now taken care of in develop and will work properly in 3.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants