Add --fixedStep option for bigwigCompare #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgruening
approved these changes
Apr 4, 2023
| @@ -93,6 +93,11 @@ def parse_arguments(args=None): | |||
| 'zeros may be wrong and this option should be used ', | |||
| action='store_true') | |||
|
|
|||
| parser.add_argument('--fixedStep', | |||
| help='Output in fixed step of bin size (as specified by --binSize), not merging ' | |||
There was a problem hiding this comment.
If anyone has a better phrasing here that would be great. I think the PR is fine but the sentences is a bit confusing for me.
There was a problem hiding this comment.
Agreed the wording is a bit confusing.
Perhaps:
'Write out all bins (of size --binSize) instead of merging neighbouring bins with equal values.' ?
There was a problem hiding this comment.
I'll take it along in develop for now and will make the change afterwards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to deepTools GitHub repository! Please check the following regarding
your pull request :