Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing default legend location to 'best'. #1042

Closed
wants to merge 42 commits into from

Conversation

blaiseli
Copy link

Trying to solve #1041

Welcome to deepTools GitHub repository! Please check the following regarding
your pull request :

  • Does the PR contain new feature?
  • Does the PR contain bugfix?
  • Does the PR contain documentation changes?
  • Does the PR contain changes to the galaxy wrapper?

dpryan79 and others added 30 commits April 5, 2020 00:57
* Added dataRange to computeMatricOperation to return min,max,median and 10th and 90th percentile.

* fixed pep8

* more pep8 fix

* fixed test_sieve of azure tests

* one more fix for test_sieve

* imported pysam to test_readFiltering.py

* updated hash values for test_sieve

* fixed galaxy computeMatrixOperation.xml

* More fixes for galaxy wrapper
* Now colors can be set by user for any heatmap in plotProfile. A bug in tick index for plotting heatmap is also fixed.

* added a small description

* pep8 fix
* added auto to plotheatmap

* fixed lint, added warning message, updated the help for zmin, zmax

* galaxy test plotPCA

* lower down the delat for potPCA galaxy test

Co-authored-by: Leily Rabbani <rabbani@pc390.ie-freiburg.mpg.de>
* fix deeptools#969

* PEP8

* updated changes.txt

* fixed a little bug in parseCommon.py which caused flake8 failure.

* [WIP] added auto to plotheatmap deeptools#908 (deeptools#982)

* added auto to plotheatmap

* fixed lint, added warning message, updated the help for zmin, zmax

* galaxy test plotPCA

* lower down the delat for potPCA galaxy test

Co-authored-by: Leily Rabbani <rabbani@pc390.ie-freiburg.mpg.de>

* updated version and changes

* removed alpha from plotPCA test

* removed compare="sim_size"

Co-authored-by: Devon Ryan <devon.ryan@genedata.com>
Co-authored-by: Leily Rabbani <rabbani@pc390.ie-freiburg.mpg.de>
Co-authored-by: LeilyR <leila.rabbani@gmail.com>
Added sortUsingSamples and clusterUsingSamples to the galaxy wrapper
* updated cmp usage to fit the recent mpl updates.

* updated the requirements.txt
* change "NA" occurences in plotFingerprint.py to proper numpy.NAN

* update expected plotFingerprint output in galaxy from NA to nan
fixed xml error brought up  in 1003
Devon Ryan and others added 12 commits December 3, 2020 13:18
* Fixes for 3.4.2

* disable azure on OSX

* Closes deeptools#945

* computeMatricOperation  dataRange (deeptools#951)

* Added dataRange to computeMatricOperation to return min,max,median and 10th and 90th percentile.

* fixed pep8

* more pep8 fix

* fixed test_sieve of azure tests

* one more fix for test_sieve

* imported pysam to test_readFiltering.py

* updated hash values for test_sieve

* fixed galaxy computeMatrixOperation.xml

* More fixes for galaxy wrapper

* fixed a little typo in bamCompare (deeptools#967)

* save the output matrix of the plotheatmap in a format to be compatible with running plotheatmap on it again (deeptools#968)

* Plot profile color map (deeptools#971)

* Now colors can be set by user for any heatmap in plotProfile. A bug in tick index for plotting heatmap is also fixed.

* added a small description

* pep8 fix

* added sortUsingSamples and clusterUsingSamples to the galaxy wrapper

* [WIP] added auto to plotheatmap deeptools#908 (deeptools#982)

* added auto to plotheatmap

* fixed lint, added warning message, updated the help for zmin, zmax

* galaxy test plotPCA

* lower down the delat for potPCA galaxy test

* fix deeptools#969 (deeptools#970)

* fix deeptools#969

* PEP8

* updated changes.txt

* fixed a little bug in parseCommon.py which caused flake8 failure.

* [WIP] added auto to plotheatmap deeptools#908 (deeptools#982)

* added auto to plotheatmap

* fixed lint, added warning message, updated the help for zmin, zmax

* galaxy test plotPCA

* lower down the delat for potPCA galaxy test

* updated version and changes

* removed alpha from plotPCA test

* removed compare="sim_size"

* fixed plotHeatmap.xml by removing size from the the params and adding anitizer for the 2 new params.

* upated change.txt

* updated the doc html

Co-authored-by: Devon Ryan <dpryan79@users.noreply.github.com>
@LeilyR
Copy link
Contributor

LeilyR commented Feb 18, 2021

Could you please send your initial commit as a PR to our develop branch instead of the master? Otherwise I can quickly fix that too and close your PR.

@blaiseli
Copy link
Author

Could you please send your initial commit as a PR to our develop branch instead of the master? Otherwise I can quickly fix that too and close your PR.

Not sure exactly what you mean by "send your initial commit...". I tried to rebase on develop as you suggested.

It is probably simpler if you fix it "manually".

@blaiseli blaiseli closed this Feb 18, 2021
@LeilyR LeilyR mentioned this pull request Feb 18, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants