Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated dependencies with pip-compile #1137

Merged
merged 2 commits into from
May 18, 2022
Merged

Updated dependencies with pip-compile #1137

merged 2 commits into from
May 18, 2022

Conversation

adRn-s
Copy link
Collaborator

@adRn-s adRn-s commented May 3, 2022

The requirements.txt file is managed by another tool that consume new requirements.in files. I tried this with python 3.9.x and all tests passed (Except 7, that were already failing).

Btw, I branched from master, and I'm starting this PR to merge into develop which at the moment is 6 commits ahead of master.

@adRn-s adRn-s requested a review from LeilyR May 5, 2022 12:33
@adRn-s

This comment was marked as resolved.

@adRn-s
Copy link
Collaborator Author

adRn-s commented May 10, 2022

Ok, now the error is somewhere else downstream the galaxy tests. According to the debug log here there's been 2 line changes between the new and the expected output. Then at the bottom I see the actual diff...

--- local_file
+++ history_data
@@ -1,4 +1,4 @@
 #plotPCA --outFileNameData
 Component	bowtie2-test1.bam	bowtie2-test1.bam	Eigenvalue
 1	-0.7071067811865476	-0.7071067811865475	4.0
-2	-0.7071067811865475	0.7071067811865476	2.49319462166397e-32
+2	-0.7071067811865475	0.7071067811865476	1.2325951644078315e-32

Could it be that the Eigenvalue change is due to rounding errors? Please note that both are near zero (n ** -32), so they kind of agree.

PS: we're testing with galaxy 20.09. I will try updating this to 22.05 later.

@adRn-s adRn-s merged commit a5fc374 into develop May 18, 2022
@@ -10,15 +10,14 @@ Remember -- deepTools are available for **command line usage** as well as for
Requirements
-------------

* Python 2.7 or Python 3.x
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is python 2.7 really supported? @LeilyR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should drop python 2.7 if it's not dropped and also python 3.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants