Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle labels and comment lines in BED files better #290

Merged
merged 2 commits into from
Feb 16, 2016
Merged

Conversation

dpryan79
Copy link
Collaborator

This fixes #288, which includes the following:

  1. Comment lines at the beginning of files
  2. Adjacent label lines
  3. Files with label lines in the middle, but not one at the end

All of these caused errors before.


if ginterval.line.startswith('#'):
# check for labels with no associated entries
if groupintervals == 0:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this case should contain the previous one on line 797, thus I think that 797 and 798 are not necesary

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, good catch

@dpryan79
Copy link
Collaborator Author

Closing and reopening to trigger the travis test.

@dpryan79 dpryan79 closed this Feb 16, 2016
@dpryan79 dpryan79 reopened this Feb 16, 2016
dpryan79 added a commit that referenced this pull request Feb 16, 2016
Handle labels and comment lines in BED files better
@dpryan79 dpryan79 merged commit 2a52d6e into master Feb 16, 2016
@dpryan79 dpryan79 deleted the fix288 branch February 16, 2016 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comment lines at the beginning of BED files are incorrectly interpreted as group labels
2 participants