Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keeping notes open between edit/nonedit mode #56

Closed
Martinligabue opened this issue Oct 22, 2024 · 8 comments
Closed

Keeping notes open between edit/nonedit mode #56

Martinligabue opened this issue Oct 22, 2024 · 8 comments

Comments

@Martinligabue
Copy link

As per title, when entering edit mode with notes layer on, it should enable them in the editor too, as usually you might want to edit more notes than a single one

@deevroman
Copy link
Owner

deevroman commented Oct 22, 2024

hmm, I thought one of the latest iD releases fixed this problem. But it seems to work only if you select some note.

@Martinligabue
Copy link
Author

it keeps the note open, not the note layer though

@deevroman
Copy link
Owner

Strangely, in Firefox, I have all the notes on the map displayed

@Martinligabue
Copy link
Author

I'm in firefox too, just tested, but with the overlay in view, it's not enabled in edit, weird

@deevroman
Copy link
Owner

To avoid misunderstandings, I talk about this usage:

2024-10-22.19.18.35.mov

If this doesn't work for you, it's best to let the developers know osm.org.


Enabling the notes layer in iD even without the selected note on the osm.org, prevents this openstreetmap/iD#8042

Right now, I specifically avoid any interference with iD: iD is much more complex and easier to break/degrade performance

@Martinligabue
Copy link
Author

I see, I see that the pr is still open, I think im on the stable id, but that's how I thought of it, so probably I just have to wait for it to reach stable? in any case I see that this is not the best place, I'll open the issue in id if that will be a problem, for now this one is not needed, thanks a lot

@deevroman
Copy link
Owner

Please note that on the right there is a list of issues related to this PR
Снимок экрана 2024-10-23 в 02 07 52

@Martinligabue
Copy link
Author

thanks, I'll follow them and see if I can add something useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants