Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add queryString option to enable notes by default #8042

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

k-yle
Copy link
Collaborator

@k-yle k-yle commented Oct 1, 2020

Closes #8919, Closes #9564, Closes #6806, Closes openstreetmap/openstreetmap-website#2338

The idea is that if you're on openstreetmap.org with the notes layer enabled, and you click "Edit", then a query parameter of &notes=1 will be passed to iD so that it can enable the notes layer by default.

If accepted, this will require a follow-up PR to https://github.com/openstreetmap/openstreetmap-website to fix openstreetmap/openstreetmap-website#1212

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@quincylvania quincylvania added the api An issue with the iD API / URL parameters label Oct 2, 2020
@matkoniecz
Copy link
Contributor

matkoniecz commented Oct 9, 2020

&nodes=1?

Why not notes?

EDIT: this was PR description typo only

@k-yle
Copy link
Collaborator Author

k-yle commented Oct 9, 2020

@matkoniecz yep sorry just fixed that typo

@yaomtc
Copy link

yaomtc commented Nov 29, 2023

What did "hacktoberfest-accepted" mean? There's two other open pull requests from 2020 with that label. Three others were merged. This is a pretty small change. I can't see what the conflicts are, though.

Considering onosm.org submits notes to the map, and many notes aren't acted on for years (and thanks to this default, few editors likely see them) this would be a pretty helpful change I would think. Notes out of sight will be notes out of mind.

@matkoniecz
Copy link
Contributor

@yaomtc See https://www.digitalocean.com/blog/hacktoberfest-2022-your-mission-for-open-source#rules-to-reduce-spam

@k-yle
Copy link
Collaborator Author

k-yle commented Nov 29, 2023

I've resolved the merge conflicts, but this PR has been open for 3 years so it seems unlikely that it will be accepted.

I don't celebrate the hacktober festival, so https://github.com/openstreetmap/iD/labels/hacktoberfest-accepted could be removed by someone with permission.

@yaomtc
Copy link

yaomtc commented Nov 29, 2023

Thanks k-yle. At the very least, I hope that if it's not accepted, there would be a good reason for it.

@tordans
Copy link
Collaborator

tordans commented Feb 26, 2024

I was just looking for this topic, because I wanted to open iD with the notes layer on.

At some point, it would be great to have the osm-website add this param automatically. I looked into this recently but the osm-website code for this part is not super nice to update, this might need some more refactoring first.

Ping @tyrasd to check this PR, which looks good to me and was rebased 3 month ago.

Co-authored-by: Tobias <t@tobiasjordans.de>
@tordans
Copy link
Collaborator

tordans commented Sep 15, 2024

@k-yle can you confirm that this does already work in the newest version of iD?

I have https://www.openstreetmap.org/note/4172111#map=16/52.24273/13.66654&layers=N open and click edit and get to the nodes UI and notes are enabled in the settings.

I did not realize this changed based on the release notes but I am happy it did, so I think we can close this.

It looks like the feature is now, that when linking to a specific note, that activates the notes overlay.
So in general this PR is a bit different, but I think we don't need an additional flag for this.

@k-yle
Copy link
Collaborator Author

k-yle commented Sep 15, 2024

@tordans no, but as of 342a03b it works if you have selected a specific note.

This PR would fix the more general case, where you have the notes layer enabled on the website, and you want it to stay enabled when you click Edit

@tyrasd tyrasd merged commit 065b2e6 into openstreetmap:develop Jan 15, 2025
3 checks passed
@k-yle k-yle deleted the notes-qp branch January 16, 2025 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api An issue with the iD API / URL parameters
Projects
None yet
6 participants