add queryString option to enable notes by default

[k-yle]

Closes #8919, Closes #9564, Closes #6806, Closes openstreetmap/openstreetmap-website#2338

The idea is that if you're on openstreetmap.org with the notes layer enabled, and you click "Edit", then a query parameter of &notes=1 will be passed to iD so that it can enable the notes layer by default.

If accepted, this will require a follow-up PR to https://github.com/openstreetmap/openstreetmap-website to fix openstreetmap/openstreetmap-website#1212

[matkoniecz]

&nodes=1?

Why not notes?

EDIT: this was PR description typo only

[k-yle]

@matkoniecz yep sorry just fixed that typo

[yaomtc]

What did "hacktoberfest-accepted" mean? There's two other open pull requests from 2020 with that label. Three others were merged. This is a pretty small change. I can't see what the conflicts are, though.

Considering onosm.org submits notes to the map, and many notes aren't acted on for years (and thanks to this default, few editors likely see them) this would be a pretty helpful change I would think. Notes out of sight will be notes out of mind.

[matkoniecz]

@yaomtc See https://www.digitalocean.com/blog/hacktoberfest-2022-your-mission-for-open-source#rules-to-reduce-spam

[k-yle]

I've resolved the merge conflicts, but this PR has been open for 3 years so it seems unlikely that it will be accepted.

I don't celebrate the hacktober festival, so https://github.com/openstreetmap/iD/labels/hacktoberfest-accepted could be removed by someone with permission.

[yaomtc]

Thanks k-yle. At the very least, I hope that if it's not accepted, there would be a good reason for it.

[tordans]

I was just looking for this topic, because I wanted to open iD with the notes layer on.

At some point, it would be great to have the osm-website add this param automatically. I looked into this recently but the osm-website code for this part is not super nice to update, this might need some more refactoring first.

Ping @tyrasd to check this PR, which looks good to me and was rebased 3 month ago.

[tordans]

@k-yle can you confirm that this does already work in the newest version of iD?

I have https://www.openstreetmap.org/note/4172111#map=16/52.24273/13.66654&layers=N open and click edit and get to the nodes UI and notes are enabled in the settings.

I did not realize this changed based on the release notes but I am happy it did, so I think we can close this.

It looks like the feature is now, that when linking to a specific note, that activates the notes overlay.
So in general this PR is a bit different, but I think we don't need an additional flag for this.

[k-yle]

@tordans no, but as of 342a03b it works if you have selected a specific note.

This PR would fix the more general case, where you have the notes layer enabled on the website, and you want it to stay enabled when you click Edit