Skip to content

Commit

Permalink
docs: Update link to example repo in README (#435)
Browse files Browse the repository at this point in the history
  • Loading branch information
jasonwashburn authored Oct 18, 2024
1 parent a803dc5 commit 94665ed
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ test:

Doing so would allow running the same command (`make test`) in your local environment, dev environment, or CI workflow. This results in more repeatable environments. Stay tuned for a separate blog post that talks about this concept.

To get a better idea of what it looks like to use Build Harness operationally, take a look at [this repo](https://github.com/defenseunicorns/terraform-aws-uds-vpc) where it is used. This pattern uses a Makefile to wrap actions that utilize Build Harness to run `make test` or `make pre-commit-all`.
To get a better idea of what it looks like to use Build Harness operationally, take a look at [this repo](https://github.com/defenseunicorns/terraform-aws-vpc) where it is used. This pattern uses a Makefile to wrap actions that utilize Build Harness to run `make test` or `make pre-commit-all`.

### Contributing to Build Harness

Expand Down Expand Up @@ -140,4 +140,4 @@ A: Yes! Please submit a GitHub Issue [here](https://github.com/defenseunicorns/b

**Q: I see that Docker is installed. Isn't that dangerous?**

A: Mounting the Docker Socket is a security risk that requires other mitigations to be in place. See https://stackoverflow.com/a/41822163. Doing so will give the container root access to the host machine. No additional security risk is posed if this container is run without mounting the docker socket. It is our belief that this is safe to do on GitHub Actions hosted runners, since it is GitHub's own infrastructure that would be at risk if they didn't mitigate what would otherwise be an incredibly easy to exploit security hole. This is NOT regarded as safe to do on self-hosted runners without having taken some other mitigation step first.
A: Mounting the Docker Socket is a security risk that requires other mitigations to be in place. See <https://stackoverflow.com/a/41822163>. Doing so will give the container root access to the host machine. No additional security risk is posed if this container is run without mounting the docker socket. It is our belief that this is safe to do on GitHub Actions hosted runners, since it is GitHub's own infrastructure that would be at risk if they didn't mitigate what would otherwise be an incredibly easy to exploit security hole. This is NOT regarded as safe to do on self-hosted runners without having taken some other mitigation step first.

0 comments on commit 94665ed

Please sign in to comment.