Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: better handling of included tasks - variable merging and URL pathing #152

Merged
merged 11 commits into from
Oct 3, 2024
Merged

feat!: better handling of included tasks - variable merging and URL pathing #152

merged 11 commits into from
Oct 3, 2024

Conversation

Racer159
Copy link
Contributor

@Racer159 Racer159 commented Oct 2, 2024 •
edited
Loading

Description

Marking this as a feat since it is a change in functionality that may not be expected - really it fixes variables not being loaded when calling an included task directly and fixes pathing on remote URLs that then import local files.

Caution

⚠️ BREAKING CHANGE - This has the potential to be breaking depending on where things are defined in your setup - if you are currently relying on variables or local pathing from remote tasks to not work this may break your setup. Also #122 may be more pronounced in complex setups because we are now able to load in more tasks.

Related Issue

Fixes #133

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@Racer159 Racer159 changed the title fix: merge in variable values from directly-called included tasks fix!: merge in variable values from directly-called included tasks Oct 2, 2024
@Racer159 Racer159 changed the title fix!: merge in variable values from directly-called included tasks feat!: better handling of included tasks - variable merging and URL pathing Oct 2, 2024
@Racer159 Racer159 merged commit a165d4c into main Oct 3, 2024
8 checks passed
@Racer159 Racer159 deleted the merge-variables-from-includes branch October 3, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachariahmiller zachariahmiller zachariahmiller approved these changes

@ericwyles ericwyles ericwyles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use default var value on imported tasks
3 participants
@Racer159 @ericwyles @zachariahmiller