-
Notifications
You must be signed in to change notification settings - Fork 1
Adding arm64 and buildx support to the dockerfile and github actions #70
Conversation
Python took like 30 minutes to install on the arm container 🤔 |
I got the arm container build time from 53~ mins to about 12 mins by removing the asdf python and make installations. Instead we install make and pip3 (checkov asdf plugin |
@zack-is-cool As I was reviewing I ran across a much simpler example of doing this. Do you know whether this is something that would work for us? Or is the more complex version as it is here in the PR the only way? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only overall concern is that doing this removes the ability to easily switch python versions. However, I don't believe that's something that anyone using this image needs right now, so I'm good with it if it saves tons of time in the build process. If feedback comes out that different python versions need to be used we may need to reevaluate.
Resolves #69