Skip to content
This repository has been archived by the owner on Jun 8, 2023. It is now read-only.

Adding arm64 and buildx support to the dockerfile and github actions #70

Merged
merged 14 commits into from
May 23, 2023

Conversation

zack-is-cool
Copy link
Member

Resolves #69

@zack-is-cool
Copy link
Member Author

Python took like 30 minutes to install on the arm container 🤔

@zack-is-cool
Copy link
Member Author

zack-is-cool commented May 23, 2023

I got the arm container build time from 53~ mins to about 12 mins by removing the asdf python and make installations.

Instead we install make and pip3 (checkov asdf plugin whiches for pip3) with dnf.
Still slow, but at-least bearable

@RothAndrew
Copy link
Member

@zack-is-cool As I was reviewing I ran across a much simpler example of doing this. Do you know whether this is something that would work for us? Or is the more complex version as it is here in the PR the only way?

https://github.com/docker/docs/blob/3275456427dbe05c249f3215cefa83ad27219918/build/ci/github-actions/examples.md

Copy link
Member

@RothAndrew RothAndrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only overall concern is that doing this removes the ability to easily switch python versions. However, I don't believe that's something that anyone using this image needs right now, so I'm good with it if it saves tons of time in the build process. If feedback comes out that different python versions need to be used we may need to reevaluate.

.github/workflows/release.yml Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
.github/workflows/verify-build.yml Outdated Show resolved Hide resolved
.github/workflows/verify-build.yml Outdated Show resolved Hide resolved
.github/workflows/verify-build.yml Outdated Show resolved Hide resolved
@RothAndrew RothAndrew enabled auto-merge (squash) May 23, 2023 20:25
@RothAndrew RothAndrew merged commit ac3d742 into main May 23, 2023
@RothAndrew RothAndrew deleted the feature/add_arm branch May 23, 2023 20:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add support for arm64 not-a-build-harness
2 participants