Revert "Undo regexp work to revisit on a separate PR"

This reverts commit 257c4b8.

src/lib/capability.ts

@@ -345,9 +345,9 @@ export class Capability implements CapabilityExport {
       return { ...commonChain, WithName, WithNameRegex };
     }
 
-    function InNamespaceRegex(...namespaces: RegExp[]): BindingWithName<T> {
+    function InNamespaceRegex(...namespaces: string[]): BindingWithName<T> {
       Log.debug(`Add regex namespaces filter ${namespaces}`, prefix);
-      binding.filters.regexNamespaces.push(...namespaces.map(regex => regex.source));
+      binding.filters.regexNamespaces.push(...namespaces);
       return { ...commonChain, WithName, WithNameRegex };
     }
 
@@ -357,9 +357,9 @@ export class Capability implements CapabilityExport {
       return commonChain;
     }
 
-    function WithNameRegex(regexName: RegExp): BindingFilter<T> {
+    function WithNameRegex(regexName: string): BindingFilter<T> {
       Log.debug(`Add regex name filter ${regexName}`, prefix);
-      binding.filters.regexName = regexName.source;
+      binding.filters.regexName = regexName;
       return commonChain;
     }
 

src/lib/filter/adjudicators.ts

@@ -117,8 +117,11 @@ export const definesNameRegex = pipe(definedNameRegex, equals(""), not);
 export const definedNamespaces = pipe(binding => binding?.filters?.namespaces, defaultTo([]));
 export const definesNamespaces = pipe(definedNamespaces, equals([]), not);
 
-export const definedNamespaceRegexes = pipe(binding => binding?.filters?.regexNamespaces, defaultTo([]));
-export const definesNamespaceRegexes = pipe(definedNamespaceRegexes, equals([]), not);
+export const definedNamespaceRegexes = pipe(
+  (binding: Binding): string[] => binding.filters.regexNamespaces,
+  defaultTo<string[]>([]),
+);
+export const definesNamespaceRegexes = pipe(definedNamespaceRegexes, equals([] as string[]), not);
 
 export const definedAnnotations = pipe((binding: Partial<Binding>) => binding?.filters?.annotations, defaultTo({}));
 export const definesAnnotations = pipe(definedAnnotations, equals({}), not);
@@ -202,12 +205,16 @@ export const mismatchedNamespace = allPass([
 export const mismatchedNamespaceRegex = allPass([
   // Check if `definesNamespaceRegexes` returns true
   pipe(nthArg(0), definesNamespaceRegexes),
-  pipe((binding, kubernetesObject) =>
-    pipe(
-      any((regEx: string) => new RegExp(regEx).test(carriedNamespace(kubernetesObject))),
-      not,
-    )(definedNamespaceRegexes(binding)),
-  ),
+
+  // Check if no regex matches
+  (binding: Binding, kubernetesObject: KubernetesObject) => {
+    // Convert definedNamespaceRegexes(binding) from string[] to RegExp[]
+    const regexArray = definedNamespaceRegexes(binding).map(regexStr => new RegExp(regexStr));
+
+    // Check if no regex matches the namespace of the Kubernetes object
+    const result = not(any((regEx: RegExp) => regEx.test(carriedNamespace(kubernetesObject)), regexArray));
+    return result;
+  },
 ]);
 
 export const metasMismatch = pipe(

src/lib/helpers.ts

@@ -237,7 +237,7 @@ export function generateWatchNamespaceError(
   return err.replace(/\.([^ ])/g, ". $1");
 }
 
-// namespaceComplianceValidator ensures that capability bindings respect ignored and capability namespaces
+// namespaceComplianceValidator ensures that capability binds respect ignored and capability namespaces
 export function namespaceComplianceValidator(capability: CapabilityExport, ignoredNamespaces?: string[]) {
   const { namespaces: capabilityNamespaces, bindings, name } = capability;
   const bindingNamespaces: string[] = bindings.flatMap((binding: Binding) => binding.filters.namespaces);

src/lib/types.ts

@@ -143,14 +143,14 @@ export type BindingWithName<T extends GenericClass> = BindingFilter<T> & {
   /** Only apply the action if the resource name matches the specified name. */
   WithName: (name: string) => BindingFilter<T>;
   /** Only apply the action if the resource name matches the specified regex name. */
-  WithNameRegex: (name: RegExp) => BindingFilter<T>;
+  WithNameRegex: (name: string) => BindingFilter<T>;
 };
 
 export type BindingAll<T extends GenericClass> = BindingWithName<T> & {
   /** Only apply the action if the resource is in one of the specified namespaces.*/
   InNamespace: (...namespaces: string[]) => BindingWithName<T>;
   /** Only apply the action if the resource is in one of the specified regex namespaces.*/
-  InNamespaceRegex: (...namespaces: RegExp[]) => BindingWithName<T>;
+  InNamespaceRegex: (...namespaces: string[]) => BindingWithName<T>;
 };
 
 export type CommonActionChain<T extends GenericClass> = MutateActionChain<T> & {