You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe what should be investigated or refactored
helpers.ts's filterNoMatchReason() uses chained ternary expression to filter data. This is a very similar problem solved with FilterChains in shouldSkipRequest.ts. We should adopt a similar approach in this file to reduce complexity.
We'll know were done when the filterNoMatchReason() function does not flag on any linter warnings and makes a call to filterChain.execute() to process data.
Links to any relevant code
See description.
Additional context
N/A
The text was updated successfully, but these errors were encountered:
Describe what should be investigated or refactored
helpers.ts's
filterNoMatchReason()
uses chained ternary expression to filter data. This is a very similar problem solved with FilterChains in shouldSkipRequest.ts. We should adopt a similar approach in this file to reduce complexity.We'll know were done when the
filterNoMatchReason()
function does not flag on any linter warnings and makes a call tofilterChain.execute()
to process data.Links to any relevant code
See description.
Additional context
N/A
The text was updated successfully, but these errors were encountered: