Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a way to make Pepr generate the image pull secret #890

Closed
cmwylie19 opened this issue Jun 13, 2024 · 0 comments · Fixed by #911
Closed

Create a way to make Pepr generate the image pull secret #890

cmwylie19 opened this issue Jun 13, 2024 · 0 comments · Fixed by #911
Assignees
@cmwylie19
Labels
enhancement New feature or request uds Tracked by UDS project. Adds to UDS Inbox when applied.
Milestone
v0.32.4

Comments

@cmwylie19
Copy link
Collaborator

cmwylie19 commented Jun 13, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.

Create a function for deploying an image pull secret to the cluster. It should be dynamic, like npx pepr deploy to avoid leaking credentials to git.

The command should use the email and password to create the secret

building the pull secret.

The command should also create the pepr-system namespace. This should all be executed through the Kubernetes-Fluent-Client

Describe the solution you'd like

  • Given I need to use the IB image
  • When I need to create the image pull secret
  • Then Pepr cli can deploy it for me

Describe alternatives you've considered

(optional) A clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.
@cmwylie19 cmwylie19 added enhancement New feature or request uds Tracked by UDS project. Adds to UDS Inbox when applied. labels Jun 13, 2024
@cmwylie19 cmwylie19 added this to the v0.33.0 milestone Jun 17, 2024
@cmwylie19 cmwylie19 self-assigned this Jun 20, 2024
@cmwylie19 cmwylie19 mentioned this issue Jun 21, 2024
Merged
5 tasks
cmwylie19 added a commit that referenced this issue Jun 21, 2024
@cmwylie19
chore: deploy image pull secret (#911)
248789f 
## Description

Provides a safe way to deploy an `imagePullSecret`, which is necessary
to deploy from the Iron Bank. This is part of an effort to improve the
overall Iron Bank experience.

```bash
npx ts-node ../src/cli.ts deploy --pullSecret="regcred" --docker-server="registry1.dso.mil" --docker-username="user" --docker-email="email@domain.com" --docker-password=""
```

## Related Issue

Fixes #890 
<!-- or -->
Relates to #

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging

- [ ] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request)
followed

---------

Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmwylie19 cmwylie19

Labels
enhancement New feature or request uds Tracked by UDS project. Adds to UDS Inbox when applied.
Projects
Pepr Project Board
Archived in project
Milestone
v0.32.4
Development

Successfully merging a pull request may close this issue.

chore: deploy image pull secret defenseunicorns/pepr
1 participant
@cmwylie19