Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add typing support to regex-related adjudicators #1484

Draft
wants to merge 56 commits into
base: main
Choose a base branch
from

Conversation

samayer12
Copy link
Collaborator

@samayer12 samayer12 commented Nov 22, 2024

Description

This PR adds typing support for regex-related adjudicators. Merge this in after #1402.

End to End Test:
(See Pepr Excellent Examples)

Related Issue

Relates to #1397, #1402

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 89.87342% with 8 lines in your changes missing coverage. Please review.

Project coverage is 78.65%. Comparing base (2da08c2) to head (7f1bbec).

Files with missing lines Patch % Lines
src/lib/capability.ts 0.00% 4 Missing ⚠️
src/lib/filter/adjudicators.ts 90.47% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1484      +/-   ##
==========================================
+ Coverage   78.56%   78.65%   +0.09%     
==========================================
  Files          38       39       +1     
  Lines        1717     1743      +26     
  Branches      410      418       +8     
==========================================
+ Hits         1349     1371      +22     
- Misses        339      370      +31     
+ Partials       29        2      -27     
Files with missing lines Coverage Δ
src/lib/filter/adjudicators/defaultTestObjects.ts 100.00% <100.00%> (ø)
src/lib/filter/filter.ts 97.77% <100.00%> (+0.27%) ⬆️
src/lib/helpers.ts 97.93% <100.00%> (-0.03%) ⬇️
src/lib/capability.ts 94.90% <0.00%> (ø)
src/lib/filter/adjudicators.ts 97.10% <90.47%> (-2.90%) ⬇️

... and 7 files with indirect coverage changes

---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant