chore: watch_failure template for reporting watch failures #1682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1682 +/- ##
=======================================
Coverage 79.52% 79.52%
=======================================
Files 48 48
Lines 2090 2090
Branches 461 430 -31
=======================================
Hits 1662 1662
- Misses 398 426 +28
+ Partials 30 2 -28 |
5 tasks
cmwylie19
commented
Jan 17, 2025
cmwylie19
commented
Jan 17, 2025
cmwylie19
commented
Jan 17, 2025
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
btlghrants
approved these changes
Jan 17, 2025
mjnagel
added a commit
to defenseunicorns/uds-core
that referenced
this pull request
Jan 21, 2025
## Description After chatting with @mjnagel and him confirming this is a descent idea I decided to take a shot at this PR that adds debugging section to the UDS Core docs, with a link to information about watch behavior. Background: Sometimes users immediately roll the pods when troubleshooting around watch, this causes us to lose the info about whether an event was missed. Being it is almost impossible to catch those events those times are really key. Please let me know any changes you would like to see. Original PR and comments from [pepr-docs](defenseunicorns/uds-docs#125) This relates to a `watch_failure.md` [issue template](defenseunicorns/pepr#1682) that is going into Pepr. ## Related Issue Fixes # <!-- or --> Relates to # ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Other (security config, docs update, etc) ## Steps to Validate - If this PR introduces new functionality to UDS Core or addresses a bug, please document the steps to test the changes. ## Checklist before merging - [x] Test, docs, adr added or updated as needed - [x] [Contributor Guide](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md) followed --------- Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com> Co-authored-by: Micah Nagel <micah.nagel@defenseunicorns.com>
tamirazrab
pushed a commit
to tamirazrab/pepr
that referenced
this pull request
Feb 10, 2025
…icorns#1682) ## Description Adds a watch failure template with strict criteria for reporting in order to get enough info to debug. This template is referenced in the UDS Core docs for debugging in this PR defenseunicorns/uds-core#1205 ## Related Issue Fixes # <!-- or --> Relates to # ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Other (security config, docs update, etc) ## Checklist before merging - [x] Unit, [Journey](https://github.com/defenseunicorns/pepr/tree/main/journey), [E2E Tests](https://github.com/defenseunicorns/pepr-excellent-examples), [docs](https://github.com/defenseunicorns/pepr/tree/main/docs), [adr](https://github.com/defenseunicorns/pepr/tree/main/adr) added or updated as needed - [x] [Contributor Guide Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request) followed --------- Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a watch failure template with strict criteria for reporting in order to get enough info to debug. This template is referenced in the UDS Core docs for debugging in this PR defenseunicorns/uds-core#1205
Related Issue
Fixes #
Relates to #
Type of change
Checklist before merging