-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: error on max-params #1782
Conversation
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1782 +/- ##
=======================================
Coverage 82.12% 82.12%
=======================================
Files 52 52
Lines 2215 2215
Branches 436 470 +34
=======================================
Hits 1819 1819
+ Misses 394 367 -27
- Partials 2 29 +27 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with enforcing this as an error. If we need to support more params in a function this will force us to have a discussion around function design, which should pay off in the long-run.
Looks like format is blocked pending #1728 |
Now pending #1787 |
Description
There is currently only one maxParams error, should we go ahead and enforce this with an error and then get this #1728 ready to merge with deprecation warnings?
Related Issue
Fixes #
Relates to #
Type of change
Checklist before merging