Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: include v in iron bank image #896

Merged
merged 1 commit into from
Jun 17, 2024
Merged

chore: include v in iron bank image #896

merged 1 commit into from
Jun 17, 2024

Conversation

cmwylie19
Copy link
Collaborator

Description

npx pepr build --registry="Iron Bank" produces an image missing the "v" on the image tag. Manual change is necessary to correct image. Intention of this PR is to fix.

Harbor shows the current latest Pepr image as v0.32.2. Clicking the COPY PULL COMMAND button you see the actual image.

docker pull registry1.dso.mil/ironbank/opensource/defenseunicorns/pepr/controller:v0.32.2

How to test

# Build pepr-test-module on the PR branch
npm test 
cd pepr-test-module

# Update the pepr dependency to ^0.32.2 (as if npx pepr update were issued)
jq '.dependencies.pepr = "^0.32.2"' package.json > package1.json && mv package1.json package.json 

# build the module with the IB image
npx ts-node ../src/cli.ts build --registry="Iron Bank"

# read the dist to make sure the image now has v
cat dist/pepr-module-static-test.yaml | grep  "registry"

expected result (should match Harbor)

registry1.dso.mil/ironbank/opensource/defenseunicorns/pepr/controller:v0.32.2

Related Issue

Fixes #888

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@cmwylie19
chore: include v in iron bank image
7eee309 
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
btlghrants
btlghrants approved these changes Jun 17, 2024
View reviewed changes
Copy link
Collaborator

@btlghrants btlghrants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice & simple.

schaeferka
schaeferka approved these changes Jun 17, 2024
View reviewed changes
Copy link
Collaborator

@schaeferka schaeferka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed during standup to add the v for Ironbank

@btlghrants btlghrants merged commit 1779a46 into main Jun 17, 2024
13 checks passed
@btlghrants btlghrants deleted the 888 branch June 17, 2024 15:50
mjnagel pushed a commit to defenseunicorns/uds-core that referenced this pull request Jun 20, 2024
@renovate
chore(deps): update pepr (#494)
2e28897 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change | Age | Adoption | Passing |
Confidence |
|---|---|---|---|---|---|---|---|
|
[defenseunicorns/uds-common](https://togithub.com/defenseunicorns/uds-common)
| | minor | `v0.5.1` -> `v0.6.0` |
[![age](https://developer.mend.io/api/mc/badges/age/github-tags/defenseunicorns%2fuds-common/v0.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/github-tags/defenseunicorns%2fuds-common/v0.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/github-tags/defenseunicorns%2fuds-common/v0.5.1/v0.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/github-tags/defenseunicorns%2fuds-common/v0.5.1/v0.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [pepr](https://togithub.com/defenseunicorns/pepr) | dependencies |
patch | [`0.32.2` ->
`0.32.3`](https://renovatebot.com/diffs/npm/pepr/0.32.2/0.32.3) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/pepr/0.32.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/pepr/0.32.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/pepr/0.32.2/0.32.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/pepr/0.32.2/0.32.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
|
[registry1.dso.mil/ironbank/opensource/defenseunicorns/pepr/controller](https://togithub.com/defenseunicorns/pepr)
([source](https://repo1.dso.mil/dsop/opensource/defenseunicorns/pepr/controller))
| | patch | `v0.32.2` -> `v0.32.3` |
[![age](https://developer.mend.io/api/mc/badges/age/docker/registry1.dso.mil%2fironbank%2fopensource%2fdefenseunicorns%2fpepr%2fcontroller/v0.32.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/docker/registry1.dso.mil%2fironbank%2fopensource%2fdefenseunicorns%2fpepr%2fcontroller/v0.32.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/docker/registry1.dso.mil%2fironbank%2fopensource%2fdefenseunicorns%2fpepr%2fcontroller/v0.32.2/v0.32.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/docker/registry1.dso.mil%2fironbank%2fopensource%2fdefenseunicorns%2fpepr%2fcontroller/v0.32.2/v0.32.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>defenseunicorns/uds-common
(defenseunicorns/uds-common)</summary>

###
[`v0.6.0`](https://togithub.com/defenseunicorns/uds-common/releases/tag/v0.6.0)

[Compare
Source](https://togithub.com/defenseunicorns/uds-common/compare/v0.5.1...v0.6.0)

##### Features

- lula lint integration
([#&#8203;147](https://togithub.com/defenseunicorns/uds-common/issues/147))
([7f357e0](https://togithub.com/defenseunicorns/uds-common/commit/7f357e0b42859b0178e90047885494ee03542be7))

##### Miscellaneous

- add a common bundle remove task
([#&#8203;153](https://togithub.com/defenseunicorns/uds-common/issues/153))
([f3b287c](https://togithub.com/defenseunicorns/uds-common/commit/f3b287c909c626e9f11d47b9e13d79312d3f3a99))
- **deps:** update uds common support dependencies
([#&#8203;148](https://togithub.com/defenseunicorns/uds-common/issues/148))
([b5854de](https://togithub.com/defenseunicorns/uds-common/commit/b5854de37ccb9e46751c17cecd8101411f9fac32))

</details>

<details>
<summary>defenseunicorns/pepr (pepr)</summary>

###
[`v0.32.3`](https://togithub.com/defenseunicorns/pepr/releases/tag/v0.32.3)

[Compare
Source](https://togithub.com/defenseunicorns/pepr/compare/v0.32.2...v0.32.3)

#### Features

none, but mitigates
[CVE-2024-37890](https://www.tenable.com/cve/CVE-2024-37890) which was
not affecting Pepr anyway (No attack surface to exploit this).

#### What's Changed

- chore: include v in iron bank image by
[@&#8203;cmwylie19](https://togithub.com/cmwylie19) in
[defenseunicorns/pepr#896
- chore: bump github/codeql-action from 3.25.9 to 3.25.10 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[defenseunicorns/pepr#895
- chore: bump kubernetes-fluent-client from 2.6.1 to 2.6.2 in the
production-dependencies group by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[defenseunicorns/pepr#902
- chore: bump the development-dependencies group across 1 directory with
2 updates by [@&#8203;dependabot](https://togithub.com/dependabot) in
[defenseunicorns/pepr#901

**Full Changelog**:
defenseunicorns/pepr@v0.32.2...v0.32.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/defenseunicorns/uds-core).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTAuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQxMy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
rjferguson21 pushed a commit to defenseunicorns/uds-core that referenced this pull request Jul 11, 2024
@renovate
chore(deps): update pepr (#494)
aa8c7d7 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change | Age | Adoption | Passing |
Confidence |
|---|---|---|---|---|---|---|---|
|
[defenseunicorns/uds-common](https://togithub.com/defenseunicorns/uds-common)
| | minor | `v0.5.1` -> `v0.6.0` |
[![age](https://developer.mend.io/api/mc/badges/age/github-tags/defenseunicorns%2fuds-common/v0.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/github-tags/defenseunicorns%2fuds-common/v0.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/github-tags/defenseunicorns%2fuds-common/v0.5.1/v0.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/github-tags/defenseunicorns%2fuds-common/v0.5.1/v0.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [pepr](https://togithub.com/defenseunicorns/pepr) | dependencies |
patch | [`0.32.2` ->
`0.32.3`](https://renovatebot.com/diffs/npm/pepr/0.32.2/0.32.3) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/pepr/0.32.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/pepr/0.32.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/pepr/0.32.2/0.32.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/pepr/0.32.2/0.32.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
|
[registry1.dso.mil/ironbank/opensource/defenseunicorns/pepr/controller](https://togithub.com/defenseunicorns/pepr)
([source](https://repo1.dso.mil/dsop/opensource/defenseunicorns/pepr/controller))
| | patch | `v0.32.2` -> `v0.32.3` |
[![age](https://developer.mend.io/api/mc/badges/age/docker/registry1.dso.mil%2fironbank%2fopensource%2fdefenseunicorns%2fpepr%2fcontroller/v0.32.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/docker/registry1.dso.mil%2fironbank%2fopensource%2fdefenseunicorns%2fpepr%2fcontroller/v0.32.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/docker/registry1.dso.mil%2fironbank%2fopensource%2fdefenseunicorns%2fpepr%2fcontroller/v0.32.2/v0.32.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/docker/registry1.dso.mil%2fironbank%2fopensource%2fdefenseunicorns%2fpepr%2fcontroller/v0.32.2/v0.32.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>defenseunicorns/uds-common
(defenseunicorns/uds-common)</summary>

###
[`v0.6.0`](https://togithub.com/defenseunicorns/uds-common/releases/tag/v0.6.0)

[Compare
Source](https://togithub.com/defenseunicorns/uds-common/compare/v0.5.1...v0.6.0)

##### Features

- lula lint integration
([#&#8203;147](https://togithub.com/defenseunicorns/uds-common/issues/147))
([7f357e0](https://togithub.com/defenseunicorns/uds-common/commit/7f357e0b42859b0178e90047885494ee03542be7))

##### Miscellaneous

- add a common bundle remove task
([#&#8203;153](https://togithub.com/defenseunicorns/uds-common/issues/153))
([f3b287c](https://togithub.com/defenseunicorns/uds-common/commit/f3b287c909c626e9f11d47b9e13d79312d3f3a99))
- **deps:** update uds common support dependencies
([#&#8203;148](https://togithub.com/defenseunicorns/uds-common/issues/148))
([b5854de](https://togithub.com/defenseunicorns/uds-common/commit/b5854de37ccb9e46751c17cecd8101411f9fac32))

</details>

<details>
<summary>defenseunicorns/pepr (pepr)</summary>

###
[`v0.32.3`](https://togithub.com/defenseunicorns/pepr/releases/tag/v0.32.3)

[Compare
Source](https://togithub.com/defenseunicorns/pepr/compare/v0.32.2...v0.32.3)

#### Features

none, but mitigates
[CVE-2024-37890](https://www.tenable.com/cve/CVE-2024-37890) which was
not affecting Pepr anyway (No attack surface to exploit this).

#### What's Changed

- chore: include v in iron bank image by
[@&#8203;cmwylie19](https://togithub.com/cmwylie19) in
[defenseunicorns/pepr#896
- chore: bump github/codeql-action from 3.25.9 to 3.25.10 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[defenseunicorns/pepr#895
- chore: bump kubernetes-fluent-client from 2.6.1 to 2.6.2 in the
production-dependencies group by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[defenseunicorns/pepr#902
- chore: bump the development-dependencies group across 1 directory with
2 updates by [@&#8203;dependabot](https://togithub.com/dependabot) in
[defenseunicorns/pepr#901

**Full Changelog**:
defenseunicorns/pepr@v0.32.2...v0.32.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/defenseunicorns/uds-core).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTAuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQxMy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@cmwylie19 cmwylie19 self-assigned this Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schaeferka schaeferka schaeferka approved these changes

@btlghrants btlghrants btlghrants approved these changes

@jeff-mccoy jeff-mccoy Awaiting requested review from jeff-mccoy jeff-mccoy is a code owner

Assignees

@cmwylie19 cmwylie19

Labels
None yet
Projects
Pepr Project Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

npx pepr build --registry "Iron Bank" missing v
3 participants
@cmwylie19 @schaeferka @btlghrants