-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update checks for modfiles #91
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Racer159
requested review from
Noxsios,
jeff-mccoy,
lucasrod16 and
AustinAbro321
as code owners
May 23, 2024 16:58
Racer159
changed the title
chore: update checks for modfiles
chore!: update checks for modfiles
May 23, 2024
Racer159
changed the title
chore!: update checks for modfiles
chore: update checks for modfiles
May 23, 2024
Racer159
changed the title
chore: update checks for modfiles
chore!: update checks for modfiles
May 23, 2024
Racer159
changed the title
chore!: update checks for modfiles
chore: update checks for modfiles
May 23, 2024
Noxsios
reviewed
May 23, 2024
@Racer159 in the future we might want to consider It supports building multiple modules in a single pass, handles generation of changelog (from GitHub PRs or git commits), publishing GitHub releases, nightlies, etc. If there are projects where we are publishing prebuilt binaries it can sign them with cosign too. |
adding a comment |
Noxsios
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds some guardrails to release while cross-team talks happen for release engineering of
pkg
.