feat: additional functions and refactoring #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zack-is-cool
reviewed
Dec 5, 2023
Comment on lines
+108
to
+113
| dynamic_environment_variables = var.which_lambda_function == "password_rotation" ? { | ||
| users = join(",", var.users) | ||
| instance_ids = join(",", var.instance_ids) | ||
| } : var.which_lambda_function == "log_exportation" ? { | ||
| cloudwatch_logs_export_bucket = var.cloudwatch_logs_export_bucket | ||
| } : {} |
Member
There was a problem hiding this comment.
I feel like this might get annoying to scale as we add more functions using this ternary pattern.
I'd recommend moving this to multiple locals (one local for password_rotation_environment_variables, one local for log_exportation_environment_variables) and then merging them all in under environment_variables or another local if you wanted
Member
|
see thread below. I don't think we want that scenario anyway |
zack-is-cool
reviewed
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.