chore: adr for caching implementation #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decleaver
requested review from
UncleGedd,
jeff-mccoy,
mjnagel and
TristanHoladay
as code owners
decleaver
changed the title
UncleGedd
reviewed
Jun 17, 2024
UncleGedd
reviewed
Jun 17, 2024
UncleGedd
reviewed
Jun 17, 2024
|
Awesome! Couple of suggestions:
|
Co-authored-by: UncleGedd <42304551+UncleGedd@users.noreply.github.com>
Co-authored-by: UncleGedd <42304551+UncleGedd@users.noreply.github.com>
UncleGedd
previously approved these changes
Jun 18, 2024
TristanHoladay
previously approved these changes
Jun 18, 2024
UncleGedd
approved these changes
Jun 18, 2024
jeff-mccoy
pushed a commit
that referenced
this pull request
Jun 28, 2024
Co-authored-by: UncleGedd <42304551+UncleGedd@users.noreply.github.com>
mjnagel
referenced
this pull request
in defenseunicorns/uds-core
Jul 2, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [defenseunicorns/uds-cli](https://togithub.com/defenseunicorns/uds-cli) | minor | `0.11.2` -> `0.12.0` | | [defenseunicorns/uds-cli](https://togithub.com/defenseunicorns/uds-cli) | minor | `v0.11.2` -> `v0.12.0` | --- ### Release Notes <details> <summary>defenseunicorns/uds-cli (defenseunicorns/uds-cli)</summary> ### [`v0.12.0`](https://togithub.com/defenseunicorns/uds-cli/releases/tag/v0.12.0) [Compare Source](https://togithub.com/defenseunicorns/uds-cli/compare/v0.11.2...v0.12.0) #### What's Changed - feat: uds monitor pepr by [@​jeff-mccoy](https://togithub.com/jeff-mccoy) in [https://github.com/defenseunicorns/uds-cli/pull/696](https://togithub.com/defenseunicorns/uds-cli/pull/696) - docs: remove out of place quotation by [@​zachariahmiller](https://togithub.com/zachariahmiller) in [https://github.com/defenseunicorns/uds-cli/pull/706](https://togithub.com/defenseunicorns/uds-cli/pull/706) - chore: ensure nginx shorthand in dev tests by [@​UncleGedd](https://togithub.com/UncleGedd) in [https://github.com/defenseunicorns/uds-cli/pull/700](https://togithub.com/defenseunicorns/uds-cli/pull/700) - chore(deps): update actions/checkout action to v4.1.7 by [@​renovate](https://togithub.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/697](https://togithub.com/defenseunicorns/uds-cli/pull/697) - chore(deps): update homebrew/actions digest to [`1be15ef`](https://togithub.com/defenseunicorns/uds-cli/commit/1be15ef) by [@​renovate](https://togithub.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/683](https://togithub.com/defenseunicorns/uds-cli/pull/683) - fix(deps): update module github.com/fatih/color to v1.17.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/678](https://togithub.com/defenseunicorns/uds-cli/pull/678) - fix(deps): update golang.org/x/exp digest to [`7f521ea`](https://togithub.com/defenseunicorns/uds-cli/commit/7f521ea) by [@​renovate](https://togithub.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/642](https://togithub.com/defenseunicorns/uds-cli/pull/642) - chore(deps): update github/codeql-action action to v3.25.10 by [@​renovate](https://togithub.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/649](https://togithub.com/defenseunicorns/uds-cli/pull/649) - fix(deps): update module helm.sh/helm/v3 to v3.15.2 by [@​renovate](https://togithub.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/690](https://togithub.com/defenseunicorns/uds-cli/pull/690) - chore: adr for caching implementation by [@​decleaver](https://togithub.com/decleaver) in [https://github.com/defenseunicorns/uds-cli/pull/707](https://togithub.com/defenseunicorns/uds-cli/pull/707) - chore: add monitor docs and tests by [@​UncleGedd](https://togithub.com/UncleGedd) in [https://github.com/defenseunicorns/uds-cli/pull/715](https://togithub.com/defenseunicorns/uds-cli/pull/715) - chore(deps): update zarf to v0.35.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/711](https://togithub.com/defenseunicorns/uds-cli/pull/711) - fix(engine): use k8s timestamps instead of pepr timestamps by [@​jeff-mccoy](https://togithub.com/jeff-mccoy) in [https://github.com/defenseunicorns/uds-cli/pull/717](https://togithub.com/defenseunicorns/uds-cli/pull/717) - chore(deps): update homebrew/actions digest to [`68fa6ae`](https://togithub.com/defenseunicorns/uds-cli/commit/68fa6ae) by [@​renovate](https://togithub.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/713](https://togithub.com/defenseunicorns/uds-cli/pull/713) - fix(deps): update module github.com/spf13/cobra to v1.8.1 by [@​renovate](https://togithub.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/710](https://togithub.com/defenseunicorns/uds-cli/pull/710) - chore: uds engine install adr by [@​decleaver](https://togithub.com/decleaver) in [https://github.com/defenseunicorns/uds-cli/pull/699](https://togithub.com/defenseunicorns/uds-cli/pull/699) - fix: update bundle-anatomy.md by [@​Madeline-UX](https://togithub.com/Madeline-UX) in [https://github.com/defenseunicorns/uds-cli/pull/720](https://togithub.com/defenseunicorns/uds-cli/pull/720) - chore: various doc linting fixes by [@​UnicornChance](https://togithub.com/UnicornChance) in [https://github.com/defenseunicorns/uds-cli/pull/724](https://togithub.com/defenseunicorns/uds-cli/pull/724) - feat: fall back to non-strict unmarshalling by [@​decleaver](https://togithub.com/decleaver) in [https://github.com/defenseunicorns/uds-cli/pull/721](https://togithub.com/defenseunicorns/uds-cli/pull/721) - chore(deps): update podinfo to v6.7.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/723](https://togithub.com/defenseunicorns/uds-cli/pull/723) - feat: distinguish between stdout and stderr output by [@​UncleGedd](https://togithub.com/UncleGedd) in [https://github.com/defenseunicorns/uds-cli/pull/730](https://togithub.com/defenseunicorns/uds-cli/pull/730) - fix(deps): update kubernetes packages to v0.30.2 by [@​renovate](https://togithub.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/702](https://togithub.com/defenseunicorns/uds-cli/pull/702) - chore(deps): update actions/create-github-app-token action to v1.10.2 by [@​renovate](https://togithub.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/727](https://togithub.com/defenseunicorns/uds-cli/pull/727) - feat(ci): included dependency review action by [@​naveensrinivasan](https://togithub.com/naveensrinivasan) in [https://github.com/defenseunicorns/uds-cli/pull/479](https://togithub.com/defenseunicorns/uds-cli/pull/479) - chore(deps): update actions/dependency-review-action action to v4.3.3 by [@​renovate](https://togithub.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/732](https://togithub.com/defenseunicorns/uds-cli/pull/732) - chore(deps): update actions/checkout action to v4.1.7 by [@​renovate](https://togithub.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/731](https://togithub.com/defenseunicorns/uds-cli/pull/731) - fix: ensure inspected image list is machine readable by [@​UncleGedd](https://togithub.com/UncleGedd) in [https://github.com/defenseunicorns/uds-cli/pull/734](https://togithub.com/defenseunicorns/uds-cli/pull/734) - fix: release pipeline by [@​UncleGedd](https://togithub.com/UncleGedd) in [https://github.com/defenseunicorns/uds-cli/pull/739](https://togithub.com/defenseunicorns/uds-cli/pull/739) - fix: release pipeline again by [@​UncleGedd](https://togithub.com/UncleGedd) in [https://github.com/defenseunicorns/uds-cli/pull/740](https://togithub.com/defenseunicorns/uds-cli/pull/740) #### New Contributors - [@​Madeline-UX](https://togithub.com/Madeline-UX) made their first contribution in [https://github.com/defenseunicorns/uds-cli/pull/720](https://togithub.com/defenseunicorns/uds-cli/pull/720) **Full Changelog**: defenseunicorns/uds-cli@v0.11.2...v0.12.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/defenseunicorns/uds-core). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjAuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS45IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
rjferguson21
referenced
this pull request
in defenseunicorns/uds-core
Jul 11, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [defenseunicorns/uds-cli](https://togithub.com/defenseunicorns/uds-cli) | minor | `0.11.2` -> `0.12.0` | | [defenseunicorns/uds-cli](https://togithub.com/defenseunicorns/uds-cli) | minor | `v0.11.2` -> `v0.12.0` | --- ### Release Notes <details> <summary>defenseunicorns/uds-cli (defenseunicorns/uds-cli)</summary> ### [`v0.12.0`](https://togithub.com/defenseunicorns/uds-cli/releases/tag/v0.12.0) [Compare Source](https://togithub.com/defenseunicorns/uds-cli/compare/v0.11.2...v0.12.0) #### What's Changed - feat: uds monitor pepr by [@​jeff-mccoy](https://togithub.com/jeff-mccoy) in [https://github.com/defenseunicorns/uds-cli/pull/696](https://togithub.com/defenseunicorns/uds-cli/pull/696) - docs: remove out of place quotation by [@​zachariahmiller](https://togithub.com/zachariahmiller) in [https://github.com/defenseunicorns/uds-cli/pull/706](https://togithub.com/defenseunicorns/uds-cli/pull/706) - chore: ensure nginx shorthand in dev tests by [@​UncleGedd](https://togithub.com/UncleGedd) in [https://github.com/defenseunicorns/uds-cli/pull/700](https://togithub.com/defenseunicorns/uds-cli/pull/700) - chore(deps): update actions/checkout action to v4.1.7 by [@​renovate](https://togithub.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/697](https://togithub.com/defenseunicorns/uds-cli/pull/697) - chore(deps): update homebrew/actions digest to [`1be15ef`](https://togithub.com/defenseunicorns/uds-cli/commit/1be15ef) by [@​renovate](https://togithub.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/683](https://togithub.com/defenseunicorns/uds-cli/pull/683) - fix(deps): update module github.com/fatih/color to v1.17.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/678](https://togithub.com/defenseunicorns/uds-cli/pull/678) - fix(deps): update golang.org/x/exp digest to [`7f521ea`](https://togithub.com/defenseunicorns/uds-cli/commit/7f521ea) by [@​renovate](https://togithub.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/642](https://togithub.com/defenseunicorns/uds-cli/pull/642) - chore(deps): update github/codeql-action action to v3.25.10 by [@​renovate](https://togithub.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/649](https://togithub.com/defenseunicorns/uds-cli/pull/649) - fix(deps): update module helm.sh/helm/v3 to v3.15.2 by [@​renovate](https://togithub.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/690](https://togithub.com/defenseunicorns/uds-cli/pull/690) - chore: adr for caching implementation by [@​decleaver](https://togithub.com/decleaver) in [https://github.com/defenseunicorns/uds-cli/pull/707](https://togithub.com/defenseunicorns/uds-cli/pull/707) - chore: add monitor docs and tests by [@​UncleGedd](https://togithub.com/UncleGedd) in [https://github.com/defenseunicorns/uds-cli/pull/715](https://togithub.com/defenseunicorns/uds-cli/pull/715) - chore(deps): update zarf to v0.35.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/711](https://togithub.com/defenseunicorns/uds-cli/pull/711) - fix(engine): use k8s timestamps instead of pepr timestamps by [@​jeff-mccoy](https://togithub.com/jeff-mccoy) in [https://github.com/defenseunicorns/uds-cli/pull/717](https://togithub.com/defenseunicorns/uds-cli/pull/717) - chore(deps): update homebrew/actions digest to [`68fa6ae`](https://togithub.com/defenseunicorns/uds-cli/commit/68fa6ae) by [@​renovate](https://togithub.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/713](https://togithub.com/defenseunicorns/uds-cli/pull/713) - fix(deps): update module github.com/spf13/cobra to v1.8.1 by [@​renovate](https://togithub.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/710](https://togithub.com/defenseunicorns/uds-cli/pull/710) - chore: uds engine install adr by [@​decleaver](https://togithub.com/decleaver) in [https://github.com/defenseunicorns/uds-cli/pull/699](https://togithub.com/defenseunicorns/uds-cli/pull/699) - fix: update bundle-anatomy.md by [@​Madeline-UX](https://togithub.com/Madeline-UX) in [https://github.com/defenseunicorns/uds-cli/pull/720](https://togithub.com/defenseunicorns/uds-cli/pull/720) - chore: various doc linting fixes by [@​UnicornChance](https://togithub.com/UnicornChance) in [https://github.com/defenseunicorns/uds-cli/pull/724](https://togithub.com/defenseunicorns/uds-cli/pull/724) - feat: fall back to non-strict unmarshalling by [@​decleaver](https://togithub.com/decleaver) in [https://github.com/defenseunicorns/uds-cli/pull/721](https://togithub.com/defenseunicorns/uds-cli/pull/721) - chore(deps): update podinfo to v6.7.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/723](https://togithub.com/defenseunicorns/uds-cli/pull/723) - feat: distinguish between stdout and stderr output by [@​UncleGedd](https://togithub.com/UncleGedd) in [https://github.com/defenseunicorns/uds-cli/pull/730](https://togithub.com/defenseunicorns/uds-cli/pull/730) - fix(deps): update kubernetes packages to v0.30.2 by [@​renovate](https://togithub.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/702](https://togithub.com/defenseunicorns/uds-cli/pull/702) - chore(deps): update actions/create-github-app-token action to v1.10.2 by [@​renovate](https://togithub.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/727](https://togithub.com/defenseunicorns/uds-cli/pull/727) - feat(ci): included dependency review action by [@​naveensrinivasan](https://togithub.com/naveensrinivasan) in [https://github.com/defenseunicorns/uds-cli/pull/479](https://togithub.com/defenseunicorns/uds-cli/pull/479) - chore(deps): update actions/dependency-review-action action to v4.3.3 by [@​renovate](https://togithub.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/732](https://togithub.com/defenseunicorns/uds-cli/pull/732) - chore(deps): update actions/checkout action to v4.1.7 by [@​renovate](https://togithub.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/731](https://togithub.com/defenseunicorns/uds-cli/pull/731) - fix: ensure inspected image list is machine readable by [@​UncleGedd](https://togithub.com/UncleGedd) in [https://github.com/defenseunicorns/uds-cli/pull/734](https://togithub.com/defenseunicorns/uds-cli/pull/734) - fix: release pipeline by [@​UncleGedd](https://togithub.com/UncleGedd) in [https://github.com/defenseunicorns/uds-cli/pull/739](https://togithub.com/defenseunicorns/uds-cli/pull/739) - fix: release pipeline again by [@​UncleGedd](https://togithub.com/UncleGedd) in [https://github.com/defenseunicorns/uds-cli/pull/740](https://togithub.com/defenseunicorns/uds-cli/pull/740) #### New Contributors - [@​Madeline-UX](https://togithub.com/Madeline-UX) made their first contribution in [https://github.com/defenseunicorns/uds-cli/pull/720](https://togithub.com/defenseunicorns/uds-cli/pull/720) **Full Changelog**: defenseunicorns/uds-cli@v0.11.2...v0.12.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/defenseunicorns/uds-core). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjAuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS45IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ADR
Related Issue
Relates to #653
Type of change
Checklist before merging