chore: add bundle name to bundle-sbom.tar #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TristanHoladay
requested review from
UncleGedd,
jeff-mccoy,
decleaver and
catsby
as code owners
decleaver
approved these changes
Aug 28, 2024
catsby
approved these changes
Aug 28, 2024
| func CreateSBOMArtifact(SBOMArtifactPathMap map[string]string) error { | ||
| out, err := os.Create(config.BundleSBOMTar) | ||
| func CreateSBOMArtifact(SBOMArtifactPathMap map[string]string, bundleName string) error { | ||
| out, err := os.Create(fmt.Sprintf("%s-%s", bundleName, config.BundleSBOMTar)) |
There was a problem hiding this comment.
Should we do any sanitation of the bundleName here? This goes a bit beyond just the sbom.tar name, I noticed I could put a space in the bundle name and then the tar/sbom files generated end up with empty spaces in them. Maybe there's some naming rules and validation that I missed though
There was a problem hiding this comment.
ah yeah that's a really good point. let's chat about that with the team tomorrow. could be good a conversation for sanitizing overall.
There was a problem hiding this comment.
gonna create an issue for sanitizing the bundle name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding the bundle name to the bundle-sboms.tar file name for easier distinction when working with multiple bundles.
e.g.
<bundle-name>-bundle-sboms.tarRelated Issue
Resolves #880
Type of change
Checklist before merging