Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add sensitive boolean for bundle override variables #894

Merged
merged 3 commits into from
Sep 4, 2024
Merged

feat: add sensitive boolean for bundle override variables #894

merged 3 commits into from
Sep 4, 2024

Conversation

TristanHoladay
Copy link
Collaborator

@TristanHoladay TristanHoladay commented Sep 4, 2024 •
edited
Loading

Description

Adds the Sensitive option to bundle override variables so that sensitive variables set in a uds-config.yaml can be masked in deployment output.

Related Issue

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@TristanHoladay TristanHoladay marked this pull request as ready for review September 4, 2024 14:38
@TristanHoladay
Copy link
Collaborator Author

Screenshot from 2024-09-04 08-47-40

Screenshot from 2024-09-04 08-47-13

decleaver
decleaver approved these changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@decleaver decleaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TristanHoladay TristanHoladay merged commit 586b033 into main Sep 4, 2024
17 checks passed
@TristanHoladay TristanHoladay deleted the sensitive-vars branch September 4, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@decleaver decleaver decleaver approved these changes

@UncleGedd UncleGedd Awaiting requested review from UncleGedd

@jeff-mccoy jeff-mccoy Awaiting requested review from jeff-mccoy

@catsby catsby Awaiting requested review from catsby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TristanHoladay @decleaver