Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update maru-runner to silence info log #925

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Conversation

catsby
Copy link
Collaborator

@catsby catsby commented Sep 18, 2024

Description

Remove the Saving log file note thats immediately present when running uds run by updating maru to a version that enforces log levels, and set the log level to warn.

NOTE: this PR updates uds-cli to use a branch from the maru-runner repo that has changes to logging, see defenseunicorns/maru-runner#141 . If that PR gets merged, this PR should be updated to pull from the main branch or a tagged release before merging.

Example output

Before this PR, we see a Saving log file note (as shown also in #916):

 ➜ ./build/uds-mac-apple run build-cli-mac-apple

  •  Saving log file to
       /var/folders/lk/181f8tjj7xg0c368tfmw35kr0000gn/T/maru-2024-09-18-14-33-53-205407822.log
  ✔  Completed "go list -f '{{.Version}}' -m github.com/derailed/k9s"
  ✔  Completed "go list -f '{{.Version}}' -m github.com/anchore/syft"
  [...]

After this change, if you run ./build/uds-mac-apple run build-cli-mac-apple twice, you'll see the new output (once to build the binary with the change, and a second time to actually use the new binary with the change):

 ➜ ./build/uds-mac-apple run build-cli-mac-apple
  ✔  Completed "go list -f '{{.Version}}' -m github.com/derailed/k9s"
  ✔  Completed "go list -f '{{.Version}}' -m github.com/anchore/syft"
  [...]

Related Issue

Fixes #916

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@catsby
Copy link
Collaborator Author

catsby commented Sep 19, 2024

defenseunicorns/maru-runner#141 has been merged, just waiting on the next maru release to update this PR

@catsby catsby added this to the v0.16.0 milestone Sep 20, 2024
Signed-off-by: catsby <clint@ctshryock.com>
Copy link
Collaborator

@UncleGedd UncleGedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perf

Screenshot 2024-09-20 at 1 37 09 PM

@UncleGedd UncleGedd merged commit d9f9667 into main Sep 20, 2024
7 checks passed
@UncleGedd UncleGedd deleted the silence-maru-log-note branch September 20, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove extra output from uds run
2 participants