Skip to content

Commit

Permalink
fix: wayne review changes
Browse files Browse the repository at this point in the history
  • Loading branch information
corang committed Aug 27, 2024
1 parent cc60f4b commit 8f3d5b5
Show file tree
Hide file tree
Showing 7 changed files with 14 additions and 32 deletions.
Empty file removed chart/.helmignore
Empty file.
2 changes: 1 addition & 1 deletion chart/templates/uds-package.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ spec:
remoteGenerated: IntraNamespace

# Custom rules for unanticipated scenarios
{{- range .Values.customNetworkPolicies }}
{{- range .Values.custom }}
- direction: {{ .direction }}
selector:
{{ .selector | toYaml | nindent 10 }}
Expand Down
2 changes: 1 addition & 1 deletion chart/values.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
domain: "###ZARF_VAR_DOMAIN###"

# customNetworkPolicies:
# custom:
# # Notice no `remoteGenerated` field here on custom internal rule
# - direction: Ingress
# selector:
Expand Down
10 changes: 9 additions & 1 deletion common/zarf.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
kind: ZarfPackageConfig
metadata:
name: nginx
description: UDS nginx Common
description: UDS Common Nginx Example

components:
- name: nginx
Expand All @@ -29,3 +29,11 @@ components:
name: nginx
namespace: nginx
condition: "'{.status.phase}'=Ready"
- description: Validate nginx Deployment
maxTotalSeconds: 300
wait:
cluster:
kind: Deployment
name: nginx
namespace: nginx
condition: Available
4 changes: 3 additions & 1 deletion src/nginx/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,6 @@ version: 0.1.0
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
# It is recommended to use it with quotes.
appVersion: "1.16.0"
# x-release-please-start-version
appVersion: "0.12.0"
# x-release-please-end
22 changes: 0 additions & 22 deletions src/nginx/templates/NOTES.txt

This file was deleted.

6 changes: 0 additions & 6 deletions tasks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -74,12 +74,6 @@ tasks:
- name: test
description: Test and validate cluster is deployed with nginx
actions:
- wait:
cluster:
kind: Deployment
name: nginx
namespace: nginx
condition: available
- wait:
network:
protocol: https
Expand Down

0 comments on commit 8f3d5b5

Please sign in to comment.