Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve badge verification and dep installs #316

Merged
merged 4 commits into from
Oct 22, 2024
Merged

chore: improve badge verification and dep installs #316

merged 4 commits into from
Oct 22, 2024

Conversation

Racer159
Copy link
Contributor

@Racer159 Racer159 commented Oct 21, 2024 •
edited
Loading

Description

This improves the uds-badge verification task and dependency installs for GH

Checklist before merging

  • ADR proposed if making an architectural change to the repo
  • Tests run, docs added or updated as needed

@Racer159 Racer159 requested review from a team as code owners October 21, 2024 22:25
@Racer159 Racer159 changed the title chore: improve badge verification chore: improve badge verification and dep installs Oct 21, 2024
zachariahmiller
zachariahmiller reviewed Oct 22, 2024
View reviewed changes
Copy link
Contributor

@zachariahmiller zachariahmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a note in the docs on the setup-ci option?

@Racer159
Copy link
Contributor Author

done

andrewg-xyz
andrewg-xyz previously approved these changes Oct 22, 2024
View reviewed changes
zachariahmiller
zachariahmiller previously approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@zachariahmiller zachariahmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, I'll re-approve if you make adjustments based on my couple of comments, but i really dont feel strongly about them

@Racer159 Racer159 merged commit 047cc5b into main Oct 22, 2024
16 checks passed
@Racer159 Racer159 deleted the improve-badge-verification branch October 22, 2024 15:20
@github-actions github-actions bot mentioned this pull request Oct 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachariahmiller zachariahmiller zachariahmiller approved these changes

@andrewg-xyz andrewg-xyz andrewg-xyz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Racer159 @andrewg-xyz @zachariahmiller