Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gitlab publish being broken due to bash weirdness #329

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

corang
Copy link
Contributor

@corang corang commented Oct 30, 2024

Description

When you have escaped double quotes in a bash variable bash does some weird single quote things that the command actually ran looks like this

--set 'FLAVOR="upstream"'

which breaks our stuff
Fix is to switch to a bash array for keeping track of everything:

        ARGS=(
          --set FLAVOR="$[[ inputs.flavor ]]"
          --set VERSION="$(uds-releaser show $[[ inputs.flavor ]] --version-only)"
        )

          ARGS+=(--set TARGET_REPO="$[[ inputs.target-repo ]]")

Checklist before merging

  • ADR proposed if making an architectural change to the repo
  • Tests run, docs added or updated as needed

@corang corang requested review from a team as code owners October 30, 2024 08:27
@corang
Copy link
Contributor Author

corang commented Oct 30, 2024

@corang corang merged commit e7a3c69 into main Oct 30, 2024
11 checks passed
@corang corang deleted the fix-gitlab-publish branch October 30, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants