Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add registry1 flavor for Pepr in tasks #222

Closed
TristanHoladay opened this issue Mar 4, 2024 · 0 comments · Fixed by #238
Closed

Add registry1 flavor for Pepr in tasks #222

TristanHoladay opened this issue Mar 4, 2024 · 0 comments · Fixed by #238
Labels
enhancement New feature or request

Comments

@TristanHoladay
Copy link
Contributor

When running tasks locally or in CI, we should use the Iron Bank version of the pepr controller when testing the registry1 flavor.

Solution

In the pepr-build task, conditionally tack on --custom-image registry1.dso.mil/....

Describe alternatives you've considered

could potentially use --registry-info but i think there will be issues with the username part of that.

@TristanHoladay TristanHoladay added the enhancement New feature or request label Mar 4, 2024
TristanHoladay added a commit that referenced this issue Mar 13, 2024
## Description
Use the registry1 pepr controller image when creating a registry1
flavored uds package.

> Warning
> Iron Bank stays at least a few days behind on releasing 
> the latest version of pepr.  So pepr is currently at `0.27.0`,
> but the latest IB image version is `v0.26.2`


> Note
> Wanted to do an options `input` but didn't have a clean way to
> run the conditional check for setting the image at the top level 
> instead of in tasks that call `pepr-build`

## Related Issue

Resolves #222 

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Other (security config, docs update, etc)

## Checklist before merging

- [ ] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)(https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md#submitting-a-pull-request)
followed
rjferguson21 pushed a commit that referenced this issue Jul 11, 2024
## Description
Use the registry1 pepr controller image when creating a registry1
flavored uds package.

> Warning
> Iron Bank stays at least a few days behind on releasing 
> the latest version of pepr.  So pepr is currently at `0.27.0`,
> but the latest IB image version is `v0.26.2`


> Note
> Wanted to do an options `input` but didn't have a clean way to
> run the conditional check for setting the image at the top level 
> instead of in tasks that call `pepr-build`

## Related Issue

Resolves #222 

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Other (security config, docs update, etc)

## Checklist before merging

- [ ] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)(https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md#submitting-a-pull-request)
followed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant