Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move endpointslice watch to .Reconcile() #317

Closed
mjnagel opened this issue Mar 29, 2024 · 0 comments · Fixed by #359
Closed

Move endpointslice watch to .Reconcile() #317

mjnagel opened this issue Mar 29, 2024 · 0 comments · Fixed by #359
Assignees

Comments

@mjnagel
Copy link
Contributor

mjnagel commented Mar 29, 2024

Describe what should be investigated or refactored

Currently the endpointslice for KubeAPI generated policies is handled as a Watch. This should be moved into a queue, using the Reconcile functionality to handle the processing seamlessly.

Links to any relevant code

@mjnagel mjnagel self-assigned this Apr 22, 2024
mjnagel added a commit that referenced this issue Apr 22, 2024
## Description

Adds additional debug logging around the endpointslice watch, and
switches to reconcile so this runs in a queue.

## Related Issue

Fixes #358

Fixes #317

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Other (security config, docs update, etc)

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)(https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md#submitting-a-pull-request)
followed
rjferguson21 pushed a commit that referenced this issue Jul 11, 2024
## Description

Adds additional debug logging around the endpointslice watch, and
switches to reconcile so this runs in a queue.

## Related Issue

Fixes #358

Fixes #317

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Other (security config, docs update, etc)

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)(https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md#submitting-a-pull-request)
followed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant