Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove retry-action action on registry1 docker login #160

Conversation

zachariahmiller
Copy link
Contributor

Description

revert using retry action on the docker login action for logging into registry1. A separate, followup issue will address this differently in the future. This is just reverting the change that added the reliance on the 3rd party action that wasnt serving its purpose and had a lacking update cadence.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Copy link
Contributor

@mjnagel mjnagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, noting the follow on work to add retries via a non-3rd party method.

@zachariahmiller zachariahmiller merged commit eea0c93 into main Feb 8, 2024
7 checks passed
@zachariahmiller zachariahmiller deleted the 158-remove-retry-action-that-isnt-actually-working-and-broke-on-latest-update branch February 8, 2024 15:58
jeff-mccoy pushed a commit that referenced this pull request Feb 9, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.12.0](v0.11.1...v0.12.0)
(2024-02-09)


### Features

* introduce advancedHTTP for expose field & change podLabels to selector
([#154](#154))
([1079267](1079267))


### Miscellaneous

* **deps:** pin dependencies
([#79](#79))
([bfab11e](bfab11e))
* remove retry-action action on registry1 docker login
([#160](#160))
([eea0c93](eea0c93))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
robmcelvenny pushed a commit to owen-grady/uds-core-slim-dev that referenced this pull request Jun 3, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.12.0](defenseunicorns/uds-core@v0.11.1...v0.12.0)
(2024-02-09)


### Features

* introduce advancedHTTP for expose field & change podLabels to selector
([#154](defenseunicorns/uds-core#154))
([1079267](defenseunicorns/uds-core@1079267))


### Miscellaneous

* **deps:** pin dependencies
([#79](defenseunicorns/uds-core#79))
([bfab11e](defenseunicorns/uds-core@bfab11e))
* remove retry-action action on registry1 docker login
([#160](defenseunicorns/uds-core#160))
([eea0c93](defenseunicorns/uds-core@eea0c93))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove retry action that isnt actually working and broke on latest update
2 participants