Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct incomplete deploy task #21

Merged
merged 1 commit into from
Nov 7, 2023
Merged

fix: correct incomplete deploy task #21

merged 1 commit into from
Nov 7, 2023

Conversation

mikevanhemert
Copy link
Contributor

Description

The example-bundle-k3d-istio-only task in tasks/deploy.yaml was incomplete
...

Related Issue

n/a

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

jeff-mccoy
jeff-mccoy approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@jeff-mccoy jeff-mccoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks I hadnt fully decided how to deal with that one yet

@mikevanhemert mikevanhemert merged commit 45ff5e5 into main Nov 7, 2023
3 checks passed
@mikevanhemert mikevanhemert deleted the task-fix branch November 7, 2023 05:19
@github-actions github-actions bot mentioned this pull request Nov 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff-mccoy jeff-mccoy jeff-mccoy approved these changes

@mjnagel mjnagel Awaiting requested review from mjnagel

@zachariahmiller zachariahmiller Awaiting requested review from zachariahmiller

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikevanhemert @jeff-mccoy