Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add metrics-server #35

Merged
merged 5 commits into from
Nov 15, 2023
Merged

feat: add metrics-server #35

merged 5 commits into from
Nov 15, 2023

Conversation

jeff-mccoy
Copy link
Member

@jeff-mccoy jeff-mccoy commented Nov 14, 2023 •
edited
Loading

Description

Add metrics-server with upstream images.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@jeff-mccoy
Copy link
Member Author

Comparing differences between BB and upstream the primary changes are once again: BB-specific things, Netpols, IB-images, and Istio TLS settings

Screenshot 2023-11-14 at 12 47 15 AM

@jeff-mccoy jeff-mccoy marked this pull request as ready for review November 14, 2023 07:49
@jeff-mccoy jeff-mccoy requested a review from a team as a code owner November 14, 2023 07:49
@mikevanhemert
Copy link
Contributor

Should the repo's README.md be updated to reflect metrics server is done?

@jeff-mccoy
Copy link
Member Author

Should the repo's README.md be updated to reflect metrics server is done?

...yes it should 😆

mjnagel
mjnagel approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@mjnagel mjnagel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the assumption netpols will come later with some pepr-magic.

@jeff-mccoy jeff-mccoy merged commit 8216ab9 into main Nov 15, 2023
6 checks passed
@jeff-mccoy jeff-mccoy deleted the metrics-server branch November 15, 2023 07:27
@github-actions github-actions bot mentioned this pull request Nov 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjnagel mjnagel mjnagel approved these changes

@mikevanhemert mikevanhemert mikevanhemert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeff-mccoy @mikevanhemert @mjnagel