Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): removed double-link which broke the markdown formatting in pr template #532

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

JoeHCQ1
Copy link
Contributor

@JoeHCQ1 JoeHCQ1 commented Jul 2, 2024

As is visible in the Checklist before merging section of #531, the markdown link formatting was broken by a second link where only one belonged.

Due to the shortness of the CONTRIBUTING.md document, I preferred the link to the doc as a whole over the one which directed to the PR requirements header.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Due to the shortness of the CONTRIBUTING.md document, I preferred the link
to the doc as a whole over the one which directed to the PR requirements header.
@JoeHCQ1 JoeHCQ1 self-assigned this Jul 2, 2024
@JoeHCQ1 JoeHCQ1 changed the title docs: removed double-link which broke the markdown formatting in pr template fix(docs): removed double-link which broke the markdown formatting in pr template Jul 2, 2024
@JoeHCQ1 JoeHCQ1 added the documentation Improvements or additions to documentation label Jul 2, 2024
@mjnagel mjnagel merged commit f41ced4 into main Jul 2, 2024
11 checks passed
@mjnagel mjnagel deleted the fix/fixed-broken-markdown-link-in-pr-template branch July 2, 2024 20:00
mjnagel pushed a commit that referenced this pull request Jul 8, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.23.0](v0.22.2...v0.23.0)
(2024-07-04)


### ⚠ BREAKING CHANGES

* remove emulated gitlab endpoints from keycloak
([#483](#483))

### Features

* identity group auth
([#497](#497))
([d71d83e](d71d83e))


### Bug Fixes

* **docs:** re-ordered small paragraphs, clarified wording, and added
links to tech homepages
([#531](#531))
([6b2b46b](6b2b46b))
* **docs:** removed double-link which broke the markdown formatting in
pr template
([#532](#532))
([f41ced4](f41ced4))
* **docs:** uds-config.yaml example in k3d-slim-dev README
([#530](#530))
([2e1c53e](2e1c53e))
* operator retries and error logging
([#511](#511))
([cae5aab](cae5aab))


### Miscellaneous

* **deps:** update checkout action to latest sha
([#481](#481))
([c6f0137](c6f0137))
* **deps:** update dependency weaveworks/eksctl to v0.183.0
([#499](#499))
([9cb8e4d](9cb8e4d))
* **deps:** update grafana to 11.1.0
([#380](#380))
([499058a](499058a))
* **deps:** update istio to v1.22.2
([#512](#512))
([dcdadb4](dcdadb4))
* **deps:** update jest to v29.1.5
([#485](#485))
([9c392b9](9c392b9))
* **deps:** update neuvector to 5.3.3
([#467](#467))
([261057d](261057d))
* **deps:** update pepr to 0.32.2
([#473](#473))
([ab4bee9](ab4bee9))
* **deps:** update pepr to 0.32.3
([#494](#494))
([2e28897](2e28897))
* **deps:** update pepr to 0.32.6
([#516](#516))
([a9d3eec](a9d3eec))
* **deps:** update promtail to 3.1.0
([#335](#335))
([4457fce](4457fce))
* **deps:** update uds to v0.12.0
([#521](#521))
([8e587ff](8e587ff))
* **deps:** update uds-common tasks to 0.6.1
([#498](#498))
([4aa6e33](4aa6e33))
* **deps:** update zarf to v0.35.0
([#490](#490))
([86957cf](86957cf))
* docs linting changes
([#505](#505))
([0fe2015](0fe2015))
* remove emulated gitlab endpoints from keycloak
([#483](#483))
([495960c](495960c))
* update docs for group auth and readme for docs site
([#540](#540))
([ace7041](ace7041))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
rjferguson21 pushed a commit that referenced this pull request Jul 11, 2024
… pr template (#532)

As is visible in the `Checklist before merging` section of #531, the
markdown link formatting was broken by a second link where only one
belonged.

Due to the shortness of the CONTRIBUTING.md document, I preferred the
link to the doc as a whole over the one which directed to the PR
requirements header.

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Other (security config, docs update, etc)

## Checklist before merging

- [X] Test, docs, adr added or updated as needed
- [X] [Contributor Guide
Steps](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)(https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md#submitting-a-pull-request)
followed
rjferguson21 pushed a commit that referenced this pull request Jul 11, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.23.0](v0.22.2...v0.23.0)
(2024-07-04)


### ⚠ BREAKING CHANGES

* remove emulated gitlab endpoints from keycloak
([#483](#483))

### Features

* identity group auth
([#497](#497))
([d71d83e](d71d83e))


### Bug Fixes

* **docs:** re-ordered small paragraphs, clarified wording, and added
links to tech homepages
([#531](#531))
([6b2b46b](6b2b46b))
* **docs:** removed double-link which broke the markdown formatting in
pr template
([#532](#532))
([f41ced4](f41ced4))
* **docs:** uds-config.yaml example in k3d-slim-dev README
([#530](#530))
([2e1c53e](2e1c53e))
* operator retries and error logging
([#511](#511))
([cae5aab](cae5aab))


### Miscellaneous

* **deps:** update checkout action to latest sha
([#481](#481))
([c6f0137](c6f0137))
* **deps:** update dependency weaveworks/eksctl to v0.183.0
([#499](#499))
([9cb8e4d](9cb8e4d))
* **deps:** update grafana to 11.1.0
([#380](#380))
([499058a](499058a))
* **deps:** update istio to v1.22.2
([#512](#512))
([dcdadb4](dcdadb4))
* **deps:** update jest to v29.1.5
([#485](#485))
([9c392b9](9c392b9))
* **deps:** update neuvector to 5.3.3
([#467](#467))
([261057d](261057d))
* **deps:** update pepr to 0.32.2
([#473](#473))
([ab4bee9](ab4bee9))
* **deps:** update pepr to 0.32.3
([#494](#494))
([2e28897](2e28897))
* **deps:** update pepr to 0.32.6
([#516](#516))
([a9d3eec](a9d3eec))
* **deps:** update promtail to 3.1.0
([#335](#335))
([4457fce](4457fce))
* **deps:** update uds to v0.12.0
([#521](#521))
([8e587ff](8e587ff))
* **deps:** update uds-common tasks to 0.6.1
([#498](#498))
([4aa6e33](4aa6e33))
* **deps:** update zarf to v0.35.0
([#490](#490))
([86957cf](86957cf))
* docs linting changes
([#505](#505))
([0fe2015](0fe2015))
* remove emulated gitlab endpoints from keycloak
([#483](#483))
([495960c](495960c))
* update docs for group auth and readme for docs site
([#540](#540))
([ace7041](ace7041))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants