-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add debug logs for istio injection logic #602
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjnagel
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - some of these feel slightly closer to trace logs just because of the noise. Could be interesting in the future to have CI run with trace logging enabled and change the level of these/others.
mjnagel
pushed a commit
that referenced
this pull request
Aug 6, 2024
🤖 I have created a release *beep* *boop* --- ## [0.25.1](v0.25.0...v0.25.1) (2024-08-06) ### Bug Fixes * switch metrics-server to optional everywhere ([#641](#641)) ([43c5bd5](43c5bd5)) ### Miscellaneous * add debug logs for istio injection logic ([#602](#602)) ([9075436](9075436)) * add support for public clients and disabling standard auth flow ([#630](#630)) ([38151d7](38151d7)) * **deps:** update dependency defenseunicorns/uds-common to v0.11.0 ([#617](#617)) ([997cf37](997cf37)) * **deps:** update dependency weaveworks/eksctl to v0.188.0 ([#623](#623)) ([3081044](3081044)) * **deps:** update uds to v0.14.0 ([#612](#612)) ([7fe927e](7fe927e)) * update codeowners ([#637](#637)) ([eec5017](eec5017)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds debug logs to better understand circumstances where istio injection is not occurring
Related Issue
#604
Type of change
Checklist before merging