Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add debug logs for istio injection logic #602

Merged
merged 8 commits into from
Aug 5, 2024
Merged

Conversation

rjferguson21
Copy link
Contributor

@rjferguson21 rjferguson21 commented Jul 24, 2024

Description

Adds debug logs to better understand circumstances where istio injection is not occurring

Related Issue

#604

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@rjferguson21 rjferguson21 marked this pull request as ready for review July 24, 2024 18:34
@rjferguson21 rjferguson21 requested a review from a team August 2, 2024 15:24
Copy link
Contributor

@mjnagel mjnagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - some of these feel slightly closer to trace logs just because of the noise. Could be interesting in the future to have CI run with trace logging enabled and change the level of these/others.

@mjnagel mjnagel enabled auto-merge (squash) August 5, 2024 22:04
@mjnagel mjnagel merged commit 9075436 into main Aug 5, 2024
11 checks passed
@mjnagel mjnagel deleted the istio-injection-debug branch August 5, 2024 22:26
mjnagel pushed a commit that referenced this pull request Aug 6, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.25.1](v0.25.0...v0.25.1)
(2024-08-06)


### Bug Fixes

* switch metrics-server to optional everywhere
([#641](#641))
([43c5bd5](43c5bd5))


### Miscellaneous

* add debug logs for istio injection logic
([#602](#602))
([9075436](9075436))
* add support for public clients and disabling standard auth flow
([#630](#630))
([38151d7](38151d7))
* **deps:** update dependency defenseunicorns/uds-common to v0.11.0
([#617](#617))
([997cf37](997cf37))
* **deps:** update dependency weaveworks/eksctl to v0.188.0
([#623](#623))
([3081044](3081044))
* **deps:** update uds to v0.14.0
([#612](#612))
([7fe927e](7fe927e))
* update codeowners
([#637](#637))
([eec5017](eec5017))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants