-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add backoff to operator retry mechanism #650
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjnagel
reviewed
Aug 7, 2024
mjnagel
reviewed
Aug 8, 2024
mjnagel
approved these changes
Aug 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in testing. Noting that the only real downside here is that all Package resources are in the same queue, so a backoff on a single Package delays any others from being reconciled. This would be a better experience if/when this pepr request is resolved.
mjnagel
pushed a commit
that referenced
this pull request
Aug 9, 2024
🤖 I have created a release *beep* *boop* --- ## [0.25.2](v0.25.1...v0.25.2) (2024-08-09) ### Bug Fixes * add backoff to operator retry mechanism ([#650](#650)) ([52c97fd](52c97fd)) * network allows for core netpols ([#652](#652)) ([e9b69e8](e9b69e8)) ### Miscellaneous * allow for extra keycloak gateway usage with client certs ([#648](#648)) ([7b1c474](7b1c474)) * **deps:** update dependency defenseunicorns/uds-common to v0.11.1 ([#647](#647)) ([768aa1c](768aa1c)) * **deps:** update dependency defenseunicorns/uds-common to v0.11.2 ([#653](#653)) ([f7d1ce8](f7d1ce8)) * **deps:** update grafana helm chart to v8.4.3 ([#660](#660)) ([81c7af0](81c7af0)) * **deps:** update grafana to 11.1.3 ([[#607](https://github.com/defenseunicorns/uds-core/issues/607)](https://github.com/defenseunicorns/uds-core/pull/607)) ([7b343ac](7b343ac)) * **deps:** update neuvector to 5.3.4 ([#606](#606)) ([526bff4](526bff4)) * **deps:** update pepr to 0.33.0 ([#588](#588)) ([6eee8f0](6eee8f0)) * update identity config to 0.6.0 ([#661](#661)) ([469fed8](469fed8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds delay to operator retries to fix issues with temporary failures causing
status=Failed
for PackagesOpen to suggestions/thoughts on the delay time but this is the current breakdown:
It is possible it would make more sense to retry more frequently with less delay (maybe it being exponential doesn't make sense here).
Example of what this looks like from the logs:
Related Issue
Fixes #649
Type of change
Checklist before merging