fix: add additional supported saml attributes #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UnicornChance
approved these changes
Aug 21, 2024
|
Yea, |
mjnagel
reviewed
Aug 21, 2024
| @@ -471,6 +471,8 @@ describe("Test Allowed SSO Client Attributes", () => { | |||
| "oauth2.device.authorization.grant.enabled": "true", | |||
| "pkce.code.challenge.method": "S256", | |||
| "client.session.idle.timeout": "3600", | |||
| "saml.client.signature": "false", | |||
| saml_assertion_consumer_url_post: "https://nexus.uds.dev/saml", | |||
There was a problem hiding this comment.
commenting for posterity - this looks weird but @rjferguson21 mentioned that the quotes are removed by pepr format
mjnagel
pushed a commit
that referenced
this pull request
Aug 26, 2024
🤖 I have created a release *beep* *boop* --- ## [0.26.1](v0.26.0...v0.26.1) (2024-08-23) ### Bug Fixes * add additional supported saml attributes ([#690](#690)) ([a7435bf](a7435bf)) ### Miscellaneous * **deps:** update dependency defenseunicorns/uds-common to v0.12.0 ([#692](#692)) ([a5423a3](a5423a3)) * **deps:** update test-infra to v0.0.6 ([#686](#686)) ([8341e6e](8341e6e)) * **deps:** update uds-common to v0.12.0 ([#693](#693)) ([957f388](957f388)) * **deps:** update zarf to v0.38.3 ([#694](#694)) ([c53126f](c53126f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds additional supported client attributes
Related Issue
Fixes #
Relates to #
Type of change
Checklist before merging