Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update mfa everywhere #164

Closed
wants to merge 10 commits into from
Closed

feat: update mfa everywhere #164

wants to merge 10 commits into from

Conversation

UnicornChance
Copy link
Contributor

@UnicornChance UnicornChance commented Jul 24, 2024

Description

To mitigate some security questions we've opted for over protecting users and requiring all users to setup and use MFA.

This of course requires a rework of integration tests and exploring setting up a smtp server ( more to come on this ).

What changed in the realm.json:

  • UDS Authentication

    • removed MFA flow
    • added OTP Form - Required before UDS Group Validation
  • UDS Registration

    • added OTP Form - Required before UDS Group Validation
  • UDS Reset Credentials

    • added OTP Form - Required before Reset Password
  • Update IDP

    • create new authentication flow that combines OTP Form and UDS Group Validation called MFA and Group Validation
    • Post Login Flow - MFA and Group Validation
  • Required Actions

    • configure otp to be enabled and a default action since we are requiring all new users to have this now
  • Realm.json Authentication flow cleanup

    • MFA flow is not in use anymore
    • Group Protection Authorization flow is not in use anymore
    • MFA Login flow is not in use

MFA-Flow-Comparison

Related Issue

Relates to #148 and #117

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@UnicornChance UnicornChance self-assigned this Jul 24, 2024
@UnicornChance UnicornChance requested a review from a team as a code owner July 24, 2024 14:20
@UnicornChance
Copy link
Contributor Author

Not in love with the naming scheme of x509 and noX509, looking for suggestions there if its a big enough problem.

@UnicornChance
Copy link
Contributor Author

Will evaluate other option of removing passwords ( which is the true reason we need MFA ) otherwise will leave this functionality to sit till a later date when we have more control over our realm to optionally choose different types of identity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant