Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to keycloak 25 #207

Merged
merged 13 commits into from
Sep 5, 2024
Merged

chore: update to keycloak 25 #207

merged 13 commits into from
Sep 5, 2024

Conversation

rjferguson21
Copy link
Contributor

@rjferguson21 rjferguson21 commented Sep 3, 2024

Description

Updates for Keycloak 25

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@rjferguson21 rjferguson21 marked this pull request as ready for review September 3, 2024 19:04
@rjferguson21 rjferguson21 requested a review from a team as a code owner September 3, 2024 19:04
UnicornChance
UnicornChance previously approved these changes Sep 4, 2024
Copy link
Contributor

@UnicornChance UnicornChance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, testing locally and everything is working as expected with integration tests and manual eye ball tests.

Copy link
Contributor

@mjnagel mjnagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure where to leave this comment - two fields now showing in the account UI that I think we can leave off from displaying there:

  • anti-bot location
  • access request notes

Also maybe a broader question on that UI and our strategy on what is exposed to the end user for editing - the rank/affiliation fields for example, should those be editable by the end user?

Other than these comments, validated deployment and reviewed the diffs here and all looks good.

@rjferguson21 rjferguson21 merged commit a2b86bd into main Sep 5, 2024
6 checks passed
rjferguson21 added a commit to defenseunicorns/uds-core that referenced this pull request Sep 5, 2024
## Description
* Updates to Keycloak 25
* Adds support for `advancedHTTP.redirect` to address
https://sso.uds.dev redirect to https://sso.uds.dev/realms/uds/account
* Adds task for testing Keycloak in HA with external database.
  - `uds run test-uds-core-ha --set FLAVOR=unicorn --no-progress`

Depends on
defenseunicorns/uds-identity-config#207

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging

- [ ] Test, docs, adr added or updated as needed
- [ ] [Contributor
Guide](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)
followed

---------

Co-authored-by: UnicornChance <chance@defenseunicorns.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants