feat: optional idp configuration #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
UnicornChance
added a commit
to defenseunicorns/uds-core
that referenced
this pull request
Apr 19, 2024
## Description Add values for configuring google sso. Three values: * Enable SSO * SSO Client ID * SSO Client Secret Default values create the Google IDP, however it is disabled and if enabled would require client id and client secret to be added to work properly. Values put into secret and then create environment variable from those which are referenced in the uds-identity-config realm.json. A PR will be created in uds-identity-config as well for that side of this process. ## Related Issue [ uds-identity-config PR](defenseunicorns/uds-identity-config#58) ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [x] Test, docs, adr added or updated as needed - [x] [Contributor Guide Steps](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)(https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md#submitting-a-pull-request) followed
mjnagel
approved these changes
Apr 19, 2024
rjferguson21
changed the title
rjferguson21
pushed a commit
to defenseunicorns/uds-core
that referenced
this pull request
Jul 11, 2024
## Description Add values for configuring google sso. Three values: * Enable SSO * SSO Client ID * SSO Client Secret Default values create the Google IDP, however it is disabled and if enabled would require client id and client secret to be added to work properly. Values put into secret and then create environment variable from those which are referenced in the uds-identity-config realm.json. A PR will be created in uds-identity-config as well for that side of this process. ## Related Issue [ uds-identity-config PR](defenseunicorns/uds-identity-config#58) ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [x] Test, docs, adr added or updated as needed - [x] [Contributor Guide Steps](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)(https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md#submitting-a-pull-request) followed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a default Google idp configuration to the realm.json. Utilizes environment variables that are exposed in uds-core. A PR is up there for enabling those.
Related Issue
uds-core PR
Type of change
Checklist before merging