-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement oidc sso for gitlab #61
Conversation
Also, since our main versioning tracks app version intentionally, while this is a feature technically feat: will actually force me to do a manual release if this gets merged. Technically we would want chore or something to just bump the |
@zachariahmiller in theory you should be able to affect that during the squash merge of this PR (adding |
@corang Also if the deployment is working locally for you let me know and i'll try to help debug the CI failures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably fine for now, but a few thoughts.
still need to test sso locally, will update when I know it works |
Description
barebones sso implementation using oidc
Related Issue
Closes #60
Type of change
Checklist before merging