Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement oidc sso for gitlab #61

Merged
merged 6 commits into from
Mar 8, 2024
Merged

feat: implement oidc sso for gitlab #61

merged 6 commits into from
Mar 8, 2024

Conversation

corang
Copy link
Contributor

@corang corang commented Mar 8, 2024

Description

barebones sso implementation using oidc

Related Issue

Closes #60

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@corang corang requested a review from a team as a code owner March 8, 2024 00:16
@zachariahmiller
Copy link
Contributor

Also, since our main versioning tracks app version intentionally, while this is a feature technically feat: will actually force me to do a manual release if this gets merged. Technically we would want chore or something to just bump the uds.x part of the version. This is kind of frustrating as it stands today i either have the manually edit the whole release because you make an accurate semantic commit or this shows up somewhat inaccurately as a "chore" in changelog

@mjnagel
Copy link
Contributor

mjnagel commented Mar 8, 2024

@zachariahmiller in theory you should be able to affect that during the squash merge of this PR (adding Release As: <whatever>) in that. Very much in theory though, so do what is less pain inducing.

@zachariahmiller
Copy link
Contributor

@corang Also if the deployment is working locally for you let me know and i'll try to help debug the CI failures

@corang corang requested a review from zachariahmiller March 8, 2024 18:57
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably fine for now, but a few thoughts.

tasks/publish.yaml Outdated Show resolved Hide resolved
charts/sso/templates/secret.yaml Outdated Show resolved Hide resolved
@corang
Copy link
Contributor Author

corang commented Mar 8, 2024

still need to test sso locally, will update when I know it works

@corang
Copy link
Contributor Author

corang commented Mar 8, 2024

SSO confrmed working locally
image

@zachariahmiller zachariahmiller merged commit 0ddedcf into main Mar 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementation of SSO support
5 participants