Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate env configuration to an envFrom configmap that is customizeable with additional values from Helm overrides #57

Closed
Michael-Kruggel opened this issue Apr 19, 2024 · 0 comments · Fixed by #58
Closed

Migrate env configuration to an envFrom configmap that is customizeable with additional values from Helm overrides #57

Michael-Kruggel opened this issue Apr 19, 2024 · 0 comments · Fixed by #58
Assignees
@Racer159
Labels
enhancement ✨ New feature or request

Comments

@Michael-Kruggel
Copy link
Contributor

Michael-Kruggel commented Apr 19, 2024 •
edited by Racer159
Loading

Is your feature request related to a problem? Please describe.

As Ezra I want a way to add additional environment variables to Mattermost so that I can set it up for my environment.

Describe the solution you'd like

  • Given I am including Mattermost in a bundle
  • When I override a value in the uds-mattermost-config chart
  • Then the chart will add my environment variables to a ConfigMap that MM will ingest in its 'envFrom`

Describe alternatives you've considered

We could use a Zarf var but this relies on autoIndent and would increase the API surface area for this package.

Additional context

A discussion on this feature happened on this PR
@Michael-Kruggel Michael-Kruggel added the enhancement ✨ New feature or request label Apr 19, 2024
@Michael-Kruggel Michael-Kruggel changed the title Move ENV vars to envFrom Move to envFrom Apr 19, 2024
@Racer159 Racer159 changed the title Move to envFrom Document how to add additional environment variables using the MM chart's envFrom Apr 19, 2024
@Racer159 Racer159 changed the title Document how to add additional environment variables using the MM chart's envFrom Migrate env configuration to an envFrom configmap that is customizeable with additional values from Helm overrides Apr 19, 2024
@Racer159 Racer159 self-assigned this Apr 19, 2024
@Racer159 Racer159 mentioned this issue Apr 19, 2024
Merged
5 tasks
Racer159 added a commit that referenced this issue Apr 19, 2024
@Racer159
chore: update extraEnv to envFrom (#58)
57df25a 
## Description

This updates Mattermost to use envFrom instead of extraEnv for greater
simplicity and more flexibility.

## Related Issue

Fixes #57

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Other (security config, docs update, etc)

## Checklist before merging

- [X] Test, docs, adr added or updated as needed
- [X] [Contributor Guide
Steps](https://github.com/defenseunicorns/uds-package-mattermost/blob/main/CONTRIBUTING.md#developer-workflow)
followed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Racer159 Racer159

Labels
enhancement ✨ New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: update extraEnv to envFrom defenseunicorns/uds-package-mattermost
2 participants
@Racer159 @Michael-Kruggel