feat(ui): truncating certain table cells #364
Open
+26
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillyFigueroa
requested review from
UncleGedd,
jeff-mccoy,
decleaver and
TristanHoladay
as code owners
…-that-need-to-be-truncated
…-that-need-to-be-truncated
…-that-need-to-be-truncated
…-that-need-to-be-truncated
|
Is there a reason why we only truncate certain resources (configmaps and secrets in this case)? |
UncleGedd
reviewed
Sep 23, 2024
| xOffset = event.pageX - tooltipOffset | ||
| yOffset = event.pageY - 110 | ||
| yOffset = event.pageY - 75 |
There was a problem hiding this comment.
Can we make these values dynamic instead of hardcoded?
…-that-need-to-be-truncated
koesbong
reviewed
Sep 23, 2024
| @@ -296,7 +296,7 @@ | |||
| </button> | |||
| {:else if style?.includes('truncate')} | |||
| <Tooltip title={value}> | |||
| <div class={`w-full ${style}`}> | |||
| <div class={`w-full ${style}`} style:width="100%"> | |||
There was a problem hiding this comment.
is there a class that sets 100% width so we don't use style?
There was a problem hiding this comment.
is there a class that sets 100% width so we don't use style?
w-full right above. I ll remove it. I was switching between dynamic style and the classes. FYI, this PR is on hold. Jeff and Gedd want to figure out if we can do this with no JS and use a CSS only tooltip option. Using a table here complicates layout manipulation with how tables determine widths
…-that-need-to-be-truncated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add sizing to all tables that have cells that need to be truncated so that the other columns are properly sized
Related Issue
Screenshots