Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update deployment flow image #132

Merged
merged 4 commits into from
Jul 30, 2024
Merged

Conversation

0xDiscotech
Copy link
Contributor

No description provided.

@@ -16,15 +16,16 @@ _`L2OpUSDCBridgeAdapter`_ - Contract that allows for the transfer of USDC from t

## L1 → L2 Deployment

![image](https://github.com/defi-wonderland/opUSDC/assets/165055168/ac9d0b57-03e7-40ae-b109-34d656d7539b)
![image](https://github.com/user-attachments/assets/1ec286f6-87ae-4b08-8086-ee8077a36ae3)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@excaliborr don't know how to upload them with https://github.com/defi-wonderland/opUSDC/assets/ as URL, I think I can't due to a permission reason

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to update the readme manually on github.com and drag and drog the image I think

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a big deal as is tho

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to update the readme manually on github.com and drag and drog the image I think

I did exactly like that, but the URL github created was different

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that's not a big deal tho

hexshire
hexshire previously approved these changes Jul 30, 2024
@hexshire hexshire dismissed their stale review July 30, 2024 02:04

I wanted to approve another PR

README.md Outdated

## L1 → L2 USDC Canonical Bridging

![image](https://github.com/defi-wonderland/opUSDC/assets/165055168/eaf55522-e768-463f-830b-b9305cec1e79)

## Migrating from Bridged USDC to Native USDC

![image](https://github.com/defi-wonderland/opUSDC/assets/165055168/17aebc4a-709f-4084-ab83-000e299a70bd)
![image](https://github.com/user-attachments/assets/ee032828-41eb-41f8-bb23-5ec7eaf9bcf9)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this image can you change setupNewRoles to match circle's selector transferUSDCRoles

@excaliborr excaliborr merged commit 5b94ef9 into audit/spearbit Jul 30, 2024
4 checks passed
@excaliborr excaliborr deleted the chore/update-flows branch July 30, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants