Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update ci and linter rules #174

Merged
merged 6 commits into from
Sep 17, 2024
Merged

chore: update ci and linter rules #174

merged 6 commits into from
Sep 17, 2024

Conversation

0xDiscotech
Copy link
Contributor

🤖 Linear

Closes OPT-XXX

@0xDiscotech 0xDiscotech self-assigned this Sep 16, 2024
@0xDiscotech 0xDiscotech changed the title chore: set rule to check only the last commit with commitlint on ci chore: update ci rules Sep 17, 2024
@@ -21,7 +21,7 @@
"script:migrate": "forge script script/mainnet/migration/MigrateToNative.s.sol --slow --via-ir",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image Is it me or lint commit messages in CI is checking way more than that? Could we also change that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, changed the workflow name to Lint

* chore: add foundry toml rule for fmt
@0xDiscotech 0xDiscotech changed the title chore: update ci rules chore: update ci and linter rules Sep 17, 2024
@0xDiscotech 0xDiscotech merged commit de93cb2 into dev Sep 17, 2024
4 checks passed
@0xDiscotech 0xDiscotech deleted the chore/commitlint-rule branch September 17, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants