feat: add permissioned protocol deployments to the factory #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OPT-70 Add UpgradeManager permissioned functions to the factory
|
0xDiscotech
reviewed
May 29, 2024
| */ | ||
| function whitelistMessenger(address _l1Messenger) external onlyOwner { | ||
| isL1MessengerWhitelisted[_l1Messenger] = true; | ||
| function prepareDeploymentForMessenger(address _l1Messenger, address _executor) external onlyOwner { |
There was a problem hiding this comment.
Missing a check over isMessengerDeployed not deployed?
There was a problem hiding this comment.
I dont think its neccessary as if its already deployed it would revert in the factory anyway's, this function simply sets the address that can deploy the protocol, do you think the check is important here?
0xDiscotech
previously approved these changes
May 29, 2024
hexshire
previously approved these changes
May 29, 2024
0xDiscotech
approved these changes
May 29, 2024
hexshire
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes OPT-70