fix: admin cant interact with usdc implementation #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xDiscotech
previously approved these changes
Jun 17, 2024
| * @notice Changes the admin of the USDC proxy | ||
| * @param newAdmin Address to transfer proxy administration to | ||
| * @dev Owner should always be the L2 Adapter | ||
| * @dev This contract needs to be the admin of USDC because of the USDC proxy not allowing admin to interact with implementation |
test/integration/IntegrationBase.sol
Outdated
| @@ -1,12 +1,13 @@ | |||
| // SPDX-License-Identifier: MIT | |||
| pragma solidity 0.8.25; | |||
|
|
|||
| import {IERC20} from '@openzeppelin/contracts/token/ERC20/IERC20.sol'; | |||
|
Nice catch! 🕵️ |
0xDiscotech
approved these changes
Jun 17, 2024
0xDiscotech
reviewed
Jun 17, 2024
| // Change the USDC admin so the init txs can be executed over the proxy from this contract | ||
| IUSDC(_usdcProxy).changeAdmin(_l2Adapter); | ||
| IUSDC(_usdcProxy).changeAdmin(_fallbackProxyAdmin); |
0xDiscotech
reviewed
Jun 17, 2024
| /** | ||
| * @notice Changes the admin of the USDC proxy | ||
| * @param newAdmin Address to transfer proxy administration to | ||
| * @dev Owner should always be the L2 Adapter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes OPT-XXX