test: l2 adapter permissioned flows #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OPT-104 Permissioned Flows
Only flows that start on L2 For example but not limited to:
|
excaliborr
reviewed
Jun 18, 2024
| */ | ||
| function test_UpgradeTo() public { | ||
| // Setup necessary data | ||
| vm.etch(_newImplementation, 'Legit code'); |
There was a problem hiding this comment.
lets avoid using cheatcodes besides neccessary ones like deal and prank, I would prefer to just deploy the dummy contract in integration
excaliborr
reviewed
Jun 18, 2024
| bytes memory _calldata = | ||
| abi.encodeWithSignature('upgradeToAndCall(address,bytes)', _newImplementation, _functionToCall); | ||
|
|
||
| vm.startPrank(_notOwner); |
There was a problem hiding this comment.
imo we dont need to add the revert checks in every call, its already tested in unit and makes it harder to read the actual scenario we want to test. If we keep it can you make it its own scenario
0xDiscotech
approved these changes
Jun 18, 2024
excaliborr
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes OPT-104