refactor: revert on l2factory #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: update errors * test: update l2 factory unit tests based on changes
OPT-109 Add back the reverts on the L2 Factory
Since we are going to deploy only a single L2 Factory per L2 deployments, we are safe by reverting and not tracking any other nonces. |
hexshire
reviewed
Jun 21, 2024
| @@ -174,14 +126,12 @@ contract L2OpUSDCFactory is IL2OpUSDCFactory { | |||
| * @param _initCode The creation bytecode. | |||
| * @return _newContract The 20-byte address where the contract was deployed. | |||
| */ | |||
| function _deployCreate(bytes memory _initCode) internal returns (address _newContract, bool _success) { | |||
| function _deployCreate(bytes memory _initCode) internal returns (address _newContract) { | |||
| assembly ("memory-safe") { | |||
| _newContract := create(0x0, add(_initCode, 0x20), mload(_initCode)) | |||
| } | |||
| if (_newContract == address(0) || _newContract.code.length == 0) { | |||
There was a problem hiding this comment.
Suggested change
| if (_newContract == address(0) || _newContract.code.length == 0) { | |
| if (uint160(_newContract) * _newContract.code.length == 0) { |
Thanks Doc 🫶
There was a problem hiding this comment.
Doesn´t save gas in this case XD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes OPT-109