refactor: relay message helper fns #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 24, 2024 08:05
0xDiscotech
reviewed
Jun 24, 2024
test/integration/IntegrationBase.sol
Outdated
| // NOTE: Changes current fork to optimism | ||
| vm.selectFork(optimism); | ||
| uint256 _messageNonce = L2_MESSENGER.messageNonce(); | ||
| vm.startPrank(AddressAliasHelper.applyL1ToL2Alias(address(OPTIMISM_L1_MESSENGER))); |
There was a problem hiding this comment.
Maybe using this?
Suggested change
| vm.startPrank(AddressAliasHelper.applyL1ToL2Alias(address(OPTIMISM_L1_MESSENGER))); | |
| vm.startPrank(AddressAliasHelper.applyL1ToL2Alias(address(OPTIMISM_L1_MESSENGER))); |
But if now we're not using that immutable on any other place than this, is also ok to remove it.
0xDiscotech
previously approved these changes
Jun 24, 2024
|
Nice one 🫡 |
0xDiscotech
approved these changes
Jun 24, 2024
hexshire
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes OPT-XXX