Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: addresses differ on multiple networks deployments #73

Merged
merged 8 commits into from
Jun 26, 2024

Conversation

0xDiscotech
Copy link
Contributor

Notes

Also renamed IMockCrossDomainMessenger to ITestCrossDomainMessenger

* refactor: helper functions

* feat: create multiple l2s deployment flow
* chore: add natspec over that interface
@0xDiscotech 0xDiscotech self-assigned this Jun 25, 2024
Copy link
Contributor

@excaliborr excaliborr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@excaliborr excaliborr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to update our CI to use the new env variable in the workflows, rest looks good

excaliborr
excaliborr previously approved these changes Jun 26, 2024
@0xDiscotech 0xDiscotech changed the title test: addresses differ on multiple deployments test: addresses differ on multiple networks deployments Jun 26, 2024
@excaliborr excaliborr merged commit 1c8ec63 into dev Jun 26, 2024
4 checks passed
@excaliborr excaliborr deleted the test/addresses-on-multiple-deployments branch June 26, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants