feat: set burn amounts for upgrading flow #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OPT-32 add `burnLockedUSDC()` to the BaseOpUSDCBridgeAdapter
|
hexshire
approved these changes
May 8, 2024
| * @dev Only callable by the owner | ||
| */ | ||
| function setBurnAmount(uint256 _amount) external onlyOwner { | ||
| burnAmount = _amount; |
There was a problem hiding this comment.
Not necessary but we could add a check to avoid setting the current amount again if(burnAmount == _amount) revert()
There was a problem hiding this comment.
I think a better approach would be without the revert
if (burnAmount != _amount) {
...
}
But agree that's not very necessary.
0xDiscotech
reviewed
May 8, 2024
| * @notice Burns the USDC tokens locked in the contract | ||
| * @dev The amount is determined by the burnAmount variable, which is set in the setBurnAmount function | ||
| */ | ||
| function burnLockedUSDC() external; |
There was a problem hiding this comment.
Linter warning here. However, I can push a PR later fixing all the warnings
There was a problem hiding this comment.
ye we have a bunch cause of mixed case, I will merge this and we can adjust the linter in a future PR, the styling and order was copied from the boilerplate its because in contracts we make view be after logic but variables are technically view functions in interfaces
0xDiscotech
reviewed
May 8, 2024
|
|
||
| import {IERC20} from '@openzeppelin/contracts/token/ERC20/IERC20.sol'; | ||
|
|
||
| interface IUSDC is IERC20 { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes OPT-32